From f764481a2d0a7146702fc9f9e0be9313c7913bed Mon Sep 17 00:00:00 2001 From: Ammar Date: Tue, 11 Nov 2025 14:07:10 -0600 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20fix:=20prevent=20ForceDeleteModa?= =?UTF-8?q?l=20overflow=20with=20long=20error=20logs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Added max-height constraints to prevent massive error logs from pushing the Force Delete button off-screen: - ErrorCodeBlock: max-h-[400px] with overflow-auto for scrollable logs - Modal: maxHeight support with overflow-y-auto when constrained - ForceDeleteModal: maxHeight="90vh" to ensure modal fits viewport --- src/components/ForceDeleteModal.tsx | 1 + src/components/Modal.tsx | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/components/ForceDeleteModal.tsx b/src/components/ForceDeleteModal.tsx index 8b87b0e34..c6d2f803b 100644 --- a/src/components/ForceDeleteModal.tsx +++ b/src/components/ForceDeleteModal.tsx @@ -50,6 +50,7 @@ export const ForceDeleteModal: React.FC = ({ subtitle="The workspace could not be removed normally" onClose={onClose} maxWidth="600px" + maxHeight="90vh" isLoading={isDeleting} > diff --git a/src/components/Modal.tsx b/src/components/Modal.tsx index c3307ee93..a8c45ee97 100644 --- a/src/components/Modal.tsx +++ b/src/components/Modal.tsx @@ -30,6 +30,7 @@ export const ModalContent: React.FC< className={cn( "bg-dark rounded-lg p-6 w-[90%] flex flex-col shadow-lg border border-border", "[&_h2]:mt-0 [&_h2]:mb-2 [&_h2]:text-white", + maxHeight && "overflow-y-auto", className )} style={{ maxWidth, ...(maxHeight && { maxHeight }) }} @@ -96,7 +97,8 @@ export const ErrorCodeBlock: React.FC<{ children: React.ReactNode; className?: s