From 604491d333ab92910754b9f3c018f4b5fe879915 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Fri, 21 May 2021 12:27:50 -0700 Subject: [PATCH] fix: use correct command to Open Folder on Welcome page (#3437) * chore: update CHANGELOG * fix: use openFolder in welcomePage In 1.56.2, they modified the WelcomePage use of OpenFileFolder in src/vs/workbench/contrib/debug/browser/welcomeView.ts to only use on macOS + Desktop (i.e. not Web). This caused the "Open Folder" to not work on macOS + macOS-like environments. Instead, we use OpenFolder which is a registered command and works as expected. --- CHANGELOG.md | 1 + .../contrib/welcome/page/browser/vs_code_welcome_page.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 353119cd810f..422990ff53f3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -71,6 +71,7 @@ VS Code v1.56.1 - fix: Check the logged user instead of $USER #3330 @videlanicolas - fix: Fix broken node_modules.asar symlink in npm package #3355 @code-asher - fix: Update cloud agent to fix version issue #3342 @oxy +- fix: use correct command to Open Folder on Welcome page #3437 @jsjoeio ### Documentation diff --git a/lib/vscode/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts b/lib/vscode/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts index b0023873410c..af4cb6871738 100644 --- a/lib/vscode/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts +++ b/lib/vscode/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts @@ -20,7 +20,7 @@ export default () => `

${escape(localize('welcomePage.start', "Start"))}