Add basic cross-compile code #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Mar 15, 2019
|
The |
|
IIRC the pulled nexe binary is wrong. |
kylecarbs
requested changes
Mar 27, 2019
| @@ -197,7 +215,7 @@ const buildDefaultExtensions = register("build:default-extensions", async (runne | |||
| if (!fs.existsSync(defaultExtensionsPath)) { | |||
| await copyForDefaultExtensions(); | |||
| runner.cwd = extDirPath; | |||
| const resp = await runner.execute(isWin ? "npx.cmd" : "npx", [isWin ? "gulp.cmd" : "gulp", "vscode-linux-x64", "--max-old-space-size=32384"]); | |||
| const resp = await runner.execute(isWin ? "npx.cmd" : "npx", [isWin ? "gulp.cmd" : "gulp", `vscode-linux-${linuxArch}`, "--max-old-space-size=32384"]); | |||
There was a problem hiding this comment.
We should be able to target linux from any OS since it normally builds with electron. This might not be necessary.
| @@ -64,7 +70,19 @@ const dependencyNexeBinary = register("dependency:nexe", async (runner) => { | |||
| if (!fs.existsSync(upxBinary)) { | |||
| fse.mkdirpSync(upxFolder); | |||
| runner.cwd = upxFolder; | |||
| const upxExtract = await runner.execute("bash", ["-c", "curl -L https://github.com/upx/upx/releases/download/v3.95/upx-3.95-amd64_linux.tar.xz | tar xJ --strip-components=1"]); | |||
| var upxArch = ""; | |||
| if ("ia32" === linuxArch) { | |||
There was a problem hiding this comment.
switch (linuxArch) {
...
}Might work better here.
|
This may have been solved by moving to nbin. If not I imagine this will need a few changes(or moved entirely to nbin.) |
|
Fixed by moving to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
Build script now should be able to cross compile. I most likely missed some places.
The binary builds but I did not yet test functionality.
Is there an open issue you can link to?
#35
BTW this is my first real js contribution.