Skip to content

chore: add actionlint and zizmor linters - #19459

Merged
deansheather merged 7 commits into
mainfrom
dean/zizmor
Aug 21, 2025
Merged

deansheather merged 7 commits into
mainfrom
dean/zizmor

Conversation

@deansheather

@deansheather deansheather commented Aug 21, 2025 •

Copy link
Copy Markdown
Collaborator

@ethanndickson
ethanndickson requested a review from Copilot August 21, 2025 02:47

This comment was marked as outdated.

Comment thread .github/workflows/nightly-gauntlet.yaml Resolved
Comment thread .github/workflows/ci.yaml Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two GitHub Actions linters (actionlint and zizmor) to improve security and quality of GitHub workflow files. The changes include creating a wrapper script for the zizmor Docker image, updating the Makefile to include the new linters, and fixing all linting errors across multiple workflow files.

  • Adds actionlint linter for GitHub Actions workflows
  • Adds zizmor linter (Docker-based) for GitHub Actions security scanning
  • Fixes shell quoting, environment variable usage, and other linting issues throughout workflow files

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/zizmor.sh New wrapper script for running zizmor linter via Docker
Makefile Adds actionlint and zizmor lint targets to the build system
.github/workflows/*.yaml Fixes shell quoting, variable substitution, and security issues
.github/actions/*/action.yaml Updates action definitions to fix quoting and variable usage
docs/tutorials/testing-templates.md Fixes shell quoting in code example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/release.yaml Resolved

@ethanndickson ethanndickson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🤞 🤞 🤞

@jdomeracki-coder jdomeracki-coder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 🚀

@deansheather
deansheather merged commit 8d0bc48 into main Aug 21, 2025
@deansheather
deansheather deleted the dean/zizmor branch August 21, 2025 12:14
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 21, 2025
Comment thread Makefile
.PHONY: lint/actions

lint/actions/actionlint:
go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning version in Makefile makes it difficult to upgrade, as Dpendabot doesn't detect them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants