Repository navigation
chore: add actionlint and zizmor linters - #19459
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds two GitHub Actions linters (actionlint and zizmor) to improve security and quality of GitHub workflow files. The changes include creating a wrapper script for the zizmor Docker image, updating the Makefile to include the new linters, and fixing all linting errors across multiple workflow files.
- Adds actionlint linter for GitHub Actions workflows
- Adds zizmor linter (Docker-based) for GitHub Actions security scanning
- Fixes shell quoting, environment variable usage, and other linting issues throughout workflow files
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/zizmor.sh | New wrapper script for running zizmor linter via Docker |
| Makefile | Adds actionlint and zizmor lint targets to the build system |
| .github/workflows/*.yaml | Fixes shell quoting, variable substitution, and security issues |
| .github/actions/*/action.yaml | Updates action definitions to fix quoting and variable usage |
| docs/tutorials/testing-templates.md | Fixes shell quoting in code example |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
matifali
reviewed
Aug 21, 2025
| .PHONY: lint/actions | ||
|
|
||
| lint/actions/actionlint: | ||
| go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 |
Member
There was a problem hiding this comment.
Pinning version in Makefile makes it difficult to upgrade, as Dpendabot doesn't detect them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.