Skip to content

chore: support attaching arbitrary comments to types #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

chore: support attaching arbitrary comments to types #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca18dd0
prefer using typescript node method
Emyrk Oct 16, 2025
1e16e3d
add comment
Emyrk Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions bindings/ast.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@ package bindings

import (
"fmt"
"go/token"
"go/types"

"github.com/dop251/goja"
)

type Node interface {
Expand Down Expand Up @@ -47,12 +44,6 @@ func (i Identifier) Ref() string {
return i.Prefix + i.Name
}

// Source is the golang file that an entity is sourced from.
type Source struct {
File string
Position token.Position
}

type HeritageType string

const (
Expand All @@ -76,26 +67,6 @@ func HeritageClauseExtends(args ...ExpressionType) *HeritageClause {
}
}

func (s Source) Comment(n *goja.Object) Comment {
return Comment{
SingleLine: true,
Text: fmt.Sprintf("From %s", s.File),
TrailingNewLine: false,
Node: n,
}
}

type Comment struct {
// Single or multi-line comment
SingleLine bool
Text string
TrailingNewLine bool

Node *goja.Object
}

func (c *Comment) isNode() {}

type Modifier string

const (
Expand Down
Loading