Skip to content

Commit 5d545a6

Browse files
committed
🤖 Remove unnecessary DMG signing and split artifacts
- Remove dmg.sign: true (not needed and discouraged per electron-builder docs) - Split macOS artifacts into separate x64 and arm64 uploads - The .app bundle signing is what matters, not the DMG itself _Generated with `cmux`_
1 parent d6f8396 commit 5d545a6

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

.github/workflows/build.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,19 @@ jobs:
3636
fi
3737
bun run dist:mac
3838
39-
- name: Upload macOS DMG
39+
- name: Upload macOS DMG (x64)
4040
uses: actions/upload-artifact@v4
4141
with:
42-
name: macos-dmg
43-
path: release/*.dmg
42+
name: macos-dmg-x64
43+
path: release/*-x64.dmg
44+
retention-days: 30
45+
if-no-files-found: error
46+
47+
- name: Upload macOS DMG (arm64)
48+
uses: actions/upload-artifact@v4
49+
with:
50+
name: macos-dmg-arm64
51+
path: release/*-arm64.dmg
4452
retention-days: 30
4553
if-no-files-found: error
4654

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,6 @@
118118
"entitlements": "build/entitlements.mac.plist",
119119
"entitlementsInherit": "build/entitlements.mac.plist"
120120
},
121-
"dmg": {
122-
"sign": true
123-
},
124121
"linux": {
125122
"target": "AppImage",
126123
"category": "Development",

0 commit comments

Comments
 (0)