fix: use ref for ORPCProvider cleanup to avoid stale closure

The useEffect cleanup captured state at mount time ('connecting'),
so even after transitioning to 'connected', cleanup never ran.
Now stores cleanup function in a ref that's always current.

Author: ThomasK33

src/browser/orpc/react.tsx

@@ -1,4 +1,4 @@
-import { createContext, useContext, useEffect, useState, useCallback } from "react";
+import { createContext, useContext, useEffect, useState, useCallback, useRef } from "react";
 import { createClient } from "@/common/orpc/client";
 import { RPCLink as WebSocketLink } from "@orpc/client/websocket";
 import { RPCLink as MessagePortLink } from "@orpc/client/message-port";
@@ -86,11 +86,15 @@ export const ORPCProvider = (props: ORPCProviderProps) => {
     return urlParams.get("token") ?? getStoredAuthToken();
   });
 
+  // Track cleanup function in a ref to avoid stale closure in useEffect cleanup
+  const cleanupRef = useRef<(() => void) | null>(null);
+
   const connect = useCallback(
     (token: string | null) => {
       // If client provided externally, use it directly
       if (props.client) {
         window.__ORPC_CLIENT__ = props.client;
+        cleanupRef.current = null; // External client - no cleanup needed
         setState({ status: "connected", client: props.client, cleanup: () => undefined });
         return;
       }
@@ -99,6 +103,7 @@ export const ORPCProvider = (props: ORPCProviderProps) => {
       if (window.api) {
         const { client, cleanup } = createElectronClient();
         window.__ORPC_CLIENT__ = client;
+        cleanupRef.current = cleanup;
         setState({ status: "connected", client, cleanup });
         return;
       }
@@ -113,6 +118,7 @@ export const ORPCProvider = (props: ORPCProviderProps) => {
           .ping("auth-check")
           .then(() => {
             window.__ORPC_CLIENT__ = client;
+            cleanupRef.current = cleanup;
             setState({ status: "connected", client, cleanup });
           })
           .catch((err: unknown) => {
@@ -166,9 +172,9 @@ export const ORPCProvider = (props: ORPCProviderProps) => {
     connect(authToken);
 
     return () => {
-      if (state.status === "connected") {
-        state.cleanup();
-      }
+      // Use ref to get current cleanup function - avoids stale closure issue
+      // where state captured at mount time would always be "connecting"
+      cleanupRef.current?.();
     };
     // Only run on mount and when authToken changes via handleAuthSubmit
     // eslint-disable-next-line react-hooks/exhaustive-deps