🤖 fix: enable visible reasoning for Opus 4.5 with configurable effort

Opus 4.5 now supports all thinking levels with proper effort mapping:
- off: effort='low', no thinking (fast, cheap, no visible reasoning)
- low: effort='low', thinking enabled (visible reasoning, budget-conscious)
- medium: effort='medium', thinking enabled
- high: effort='high', thinking enabled

Previously Opus 4.5 only passed the effort parameter without the thinking
parameter, which meant no visible reasoning traces were returned.

Also removed the policy restriction that prevented 'off' for Opus 4.5 -
users can now disable visible reasoning while still getting efficient
responses via effort='low'.

_Generated with mux_

Change-Id: I05239192b38babf22c7ca980d9380da718608be2
Signed-off-by: Thomas Kosiewski <tk@coder.com>

Author: ThomasK33

src/browser/utils/thinking/policy.ts

@@ -25,7 +25,6 @@ export type ThinkingPolicy = readonly ThinkingLevel[];
  *
  * Rules:
  * - openai:gpt-5-pro → ["high"] (only supported level)
- * - anthropic:claude-opus-4-5 → ["low", "medium", "high"] (effort parameter only)
  * - gemini-3 → ["low", "high"] (thinking level only)
  * - default → ["off", "low", "medium", "high"] (all levels selectable)
  *
@@ -39,12 +38,6 @@ export function getThinkingPolicyForModel(modelString: string): ThinkingPolicy {
     return ["high"];
   }
 
-  // Claude Opus 4.5 only supports effort parameter: low, medium, high (no "off")
-  // Match "anthropic:" followed by "claude-opus-4-5" with optional version suffix
-  if (modelString.includes("opus-4-5")) {
-    return ["low", "medium", "high"];
-  }
-
   // Gemini 3 Pro only supports "low" and "high" reasoning levels
   if (modelString.includes("gemini-3")) {
     return ["low", "high"];
@@ -59,8 +52,7 @@ export function getThinkingPolicyForModel(modelString: string): ThinkingPolicy {
  *
  * Fallback strategy:
  * 1. If requested level is allowed, use it
- * 2. For Opus 4.5: prefer "high" (best experience for reasoning model)
- * 3. Otherwise: prefer "medium" if allowed, else use first allowed level
+ * 2. Otherwise: prefer "medium" if allowed, else use first allowed level
  */
 export function enforceThinkingPolicy(
   modelString: string,
@@ -72,11 +64,6 @@ export function enforceThinkingPolicy(
     return requested;
   }
 
-  // Special case: Opus 4.5 defaults to "high" for best experience
-  if (modelString.includes("opus-4-5") && allowed.includes("high")) {
-    return "high";
-  }
-
   // Fallback: prefer "medium" if allowed, else use first allowed level
   return allowed.includes("medium") ? "medium" : allowed[0];
 }

src/common/types/thinking.ts

@@ -42,8 +42,8 @@ export const ANTHROPIC_THINKING_BUDGETS: Record<ThinkingLevel, number> = {
  *
  * @see https://www.anthropic.com/news/claude-opus-4-5
  */
-export const ANTHROPIC_EFFORT: Record<ThinkingLevel, "low" | "medium" | "high" | undefined> = {
-  off: undefined,
+export const ANTHROPIC_EFFORT: Record<ThinkingLevel, "low" | "medium" | "high"> = {
+  off: "low",
   low: "low",
   medium: "medium",
   high: "high",

src/common/utils/ai/providerOptions.test.ts

@@ -23,37 +23,46 @@ void mock.module("@/browser/utils/thinking/policy", () => ({
 
 describe("buildProviderOptions - Anthropic", () => {
   describe("Opus 4.5 (effort parameter)", () => {
-    test("should use effort parameter for claude-opus-4-5", () => {
+    test("should use effort and thinking parameters for claude-opus-4-5", () => {
       const result = buildProviderOptions("anthropic:claude-opus-4-5", "medium");
 
       expect(result).toEqual({
         anthropic: {
           disableParallelToolUse: false,
           sendReasoning: true,
+          thinking: {
+            type: "enabled",
+            budgetTokens: 10000, // ANTHROPIC_THINKING_BUDGETS.medium
+          },
           effort: "medium",
         },
       });
     });
 
-    test("should use effort parameter for claude-opus-4-5-20251101", () => {
+    test("should use effort and thinking parameters for claude-opus-4-5-20251101", () => {
       const result = buildProviderOptions("anthropic:claude-opus-4-5-20251101", "high");
 
       expect(result).toEqual({
         anthropic: {
           disableParallelToolUse: false,
           sendReasoning: true,
+          thinking: {
+            type: "enabled",
+            budgetTokens: 20000, // ANTHROPIC_THINKING_BUDGETS.high
+          },
           effort: "high",
         },
       });
     });
 
-    test("should omit effort when thinking is off for Opus 4.5", () => {
+    test("should use effort 'low' with no thinking when off for Opus 4.5", () => {
       const result = buildProviderOptions("anthropic:claude-opus-4-5", "off");
 
       expect(result).toEqual({
         anthropic: {
           disableParallelToolUse: false,
           sendReasoning: true,
+          effort: "low", // "off" maps to effort: "low" for efficiency
         },
       });
     });

src/common/utils/ai/providerOptions.ts

@@ -93,20 +93,34 @@ export function buildProviderOptions(
     const isOpus45 = modelName?.includes("opus-4-5") ?? false;
 
     if (isOpus45) {
-      // Opus 4.5: Use effort parameter for reasoning control
-      const effort = ANTHROPIC_EFFORT[effectiveThinking];
+      // Opus 4.5: Use effort parameter AND optionally thinking for visible reasoning
+      // - "off" or "low" → effort: "low", no thinking (fast, no visible reasoning for off)
+      // - "low" → effort: "low", thinking enabled (visible reasoning)
+      // - "medium" → effort: "medium", thinking enabled
+      // - "high" → effort: "high", thinking enabled
+      const effortLevel = ANTHROPIC_EFFORT[effectiveThinking];
+      const budgetTokens = ANTHROPIC_THINKING_BUDGETS[effectiveThinking];
       log.debug("buildProviderOptions: Anthropic Opus 4.5 config", {
-        effort,
+        effort: effortLevel,
+        budgetTokens,
         thinkingLevel: effectiveThinking,
       });
 
       const options: ProviderOptions = {
         anthropic: {
           disableParallelToolUse: false, // Always enable concurrent tool execution
           sendReasoning: true, // Include reasoning traces in requests sent to the model
+          // Enable thinking to get visible reasoning traces (only when not "off")
+          // budgetTokens sets the ceiling; effort controls how eagerly tokens are spent
+          ...(budgetTokens > 0 && {
+            thinking: {
+              type: "enabled",
+              budgetTokens,
+            },
+          }),
           // Use effort parameter (Opus 4.5 only) to control token spend
           // SDK auto-adds beta header "effort-2025-11-24" when effort is set
-          ...(effort && { effort }),
+          effort: effortLevel,
         },
       };
       log.debug("buildProviderOptions: Returning Anthropic Opus 4.5 options", options);