🤖 ci: remove push trigger on main to avoid duplicate runs #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
- Remove 'push: branches: [main]' from CI and Build workflows - Keep only merge_group and pull_request triggers - Workflows now run once in merge queue, not twice (queue + post-merge) - Docs workflow keeps push trigger (has path filters, only deploys) - Also updated propose_plan tool to recommend best option when presenting choices
ammar-agent
force-pushed
the
merge-group
branch
from
d45ffb1 to
92d39b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
push: branches: [main]from CI and Build workflowsmerge_groupandpull_requesttriggersWhy
Currently, workflows run twice for every merge:
merge_groupevent)pushevent)This change eliminates the redundant post-merge runs, reducing CI costs and execution time.
Testing
After merge, verify that:
Bonus: propose_plan tool improvement
Also updated the
propose_plantool description to instruct the agent to always provide a recommendation when presenting options to the user.Generated with
cmux