From 721d1942a57c84666a1d14fd915a680ff95f93cc Mon Sep 17 00:00:00 2001
From: Ammar <ammar+ai@ammar.io>
Date: Sun, 14 Dec 2025 11:53:04 -0600
Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20fix:=20prevent=20Tooltip=20contr?=
 =?UTF-8?q?olled/uncontrolled=20switch=20in=20DiffIndicator?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The Tooltip was conditionally spreading { open: false } when dragging/selecting
and {} otherwise, causing React to warn about switching between controlled and
uncontrolled modes.

Fix by always passing the open prop with undefined for default behavior.
---
 src/browser/components/shared/DiffRenderer.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/browser/components/shared/DiffRenderer.tsx b/src/browser/components/shared/DiffRenderer.tsx
index 9fb7d0d448..cc807f7828 100644
--- a/src/browser/components/shared/DiffRenderer.tsx
+++ b/src/browser/components/shared/DiffRenderer.tsx
@@ -901,7 +901,7 @@ export const SelectableDiffRenderer = React.memo<SelectableDiffRendererProps>(
                     }}
                     reviewButton={
                       onReviewNote && (
-                        <Tooltip {...(selection || isDragging ? { open: false } : {})}>
+                        <Tooltip open={selection || isDragging ? false : undefined}>
                           <TooltipTrigger asChild>
                             <button
                               className="pointer-events-none absolute inset-0 flex items-center justify-center rounded-sm text-[var(--color-review-accent)]/60 opacity-0 transition-opacity group-hover:pointer-events-auto group-hover:opacity-100 hover:text-[var(--color-review-accent)] active:scale-90"