Skip to content

🤖 feat: add aria-labels to ProjectSidebar and fix path text cutoff #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
Merged

🤖 feat: add aria-labels to ProjectSidebar and fix path text cutoff #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99b23cc
🤖 feat: add aria-labels to ProjectSidebar and fix path text cutoff
ammar-agent Nov 7, 2025
ab6c90e
🤖 fmt: auto-format ProjectSidebar.tsx
ammar-agent Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/components/ProjectSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ type DraggableProjectItemProps = React.PropsWithChildren<{
tabIndex?: number;
"aria-expanded"?: boolean;
"aria-controls"?: string;
"aria-label"?: string;
"data-project-path"?: string;
}>;

Expand Down Expand Up @@ -140,7 +141,7 @@ const ProjectDragLayer: React.FC = () => {
<span className="text-dim mr-1.5 text-xs">⠿</span>
<span className="text-muted mr-2 text-xs">▶</span>
<div className="min-w-0 flex-1">
<div className="text-muted-dark font-monospace truncate text-sm leading-none">
<div className="text-muted-dark font-monospace truncate text-sm leading-tight">
<span>{dirPath}</span>
<span className="text-foreground font-medium">{basename}</span>
</div>
Expand Down Expand Up @@ -475,6 +476,7 @@ const ProjectSidebarInner: React.FC<ProjectSidebarProps> = ({
tabIndex={0}
aria-expanded={isExpanded}
aria-controls={workspaceListId}
aria-label={`${isExpanded ? "Collapse" : "Expand"} project ${projectName}`}
data-project-path={projectPath}
>
<span
Expand All @@ -494,7 +496,7 @@ const ProjectSidebarInner: React.FC<ProjectSidebarProps> = ({
</span>
<div className="flex min-w-0 flex-1 items-center pr-2">
<TooltipWrapper inline>
<div className="text-muted-dark font-monospace truncate text-sm leading-none">
<div className="text-muted-dark font-monospace truncate text-sm leading-tight">
{(() => {
const abbrevPath = abbreviatePath(projectPath);
const { dirPath, basename } = splitAbbreviatedPath(abbrevPath);
Expand Down Expand Up @@ -549,7 +551,11 @@ const ProjectSidebarInner: React.FC<ProjectSidebarProps> = ({
</DraggableProjectItem>

{isExpanded && (
<div id={workspaceListId}>
<div
id={workspaceListId}
role="region"
aria-label={`Workspaces for ${projectName}`}
>
<div className="border-hover border-b px-3 py-2 pl-[22px]">
<button
onClick={() => onAddWorkspace(projectPath)}
Expand Down Expand Up @@ -635,6 +641,7 @@ const ProjectSidebarInner: React.FC<ProjectSidebarProps> = ({
<TooltipWrapper inline>
<button
onClick={onToggleCollapsed}
aria-label={collapsed ? "Expand sidebar" : "Collapse sidebar"}
className="text-muted border-dark hover:bg-hover hover:text-foreground mt-auto flex h-9 w-full cursor-pointer items-center justify-center border-t border-none bg-transparent p-0 text-sm transition-all duration-200"
>
{collapsed ? "»" : "«"}
Expand Down
1 change: 1 addition & 0 deletions src/components/WorkspaceListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ const WorkspaceListItemInner: React.FC<WorkspaceListItemProps> = ({
role="button"
tabIndex={0}
aria-current={isSelected ? "true" : undefined}
aria-label={`Select workspace ${displayName}`}
data-workspace-path={namedWorkspacePath}
data-workspace-id={workspaceId}
>
Expand Down