🤖 ci: reduce make fmt verbosity when no changes #585
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use --log-level error for prettier --write (suppresses file-by-file output) - Use --log-level warn for prettier --check (shows warnings, not verbose logs) - Add --quiet flag to ruff format commands - Redirect shfmt output to /dev/null during formatting Before: Listed every file checked with timing info (100+ lines of output) After: Only shows section headers and final success message (~6 lines) Generated with `mux`
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codex feedback: --log-level warn suppresses the file list when prettier --check fails, making it impossible to know which files need formatting. --log-level log: - Shows failing file paths when issues are found - Suppresses verbose (unchanged) messages for clean files - Maintains clean output in success case
ammario
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatter tools were outputting file-by-file status even when nothing changed, producing 100+ lines of noise. Now they only show section headers and a final success message (~6 lines).
Changes:
--log-level errorfor write,--log-level warnfor check--quietflag to suppress detailed output/dev/nullduring formattingOutput still shows warnings when files need formatting and maintains proper exit codes.
Generated with
mux