Skip to content

Conversation

@ammar-agent
Copy link
Collaborator

@ammar-agent ammar-agent commented Nov 15, 2025

WorkspaceContext owns the "pending new workspace" state, but App was still tracking its own copy. The sidebar button (and other entry points) mutate the context value, so the creation view never appeared.

  • Read pendingNewWorkspaceProject/begin/clear from WorkspaceContext in App
  • Clear the shared state after creation cancel/success
  • Update useStartWorkspaceCreation to call beginWorkspaceCreation directly

Tests: bun test src/hooks/useStartWorkspaceCreation.test.ts

Generated with mux

@ammar-agent ammar-agent force-pushed the fix-new-workspace-button branch from 8978f64 to 153e627 Compare November 15, 2025 19:41
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified it works

@ammario ammario merged commit 5f7e070 into main Nov 15, 2025
13 checks passed
@ammario ammario deleted the fix-new-workspace-button branch November 15, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants