🤖 feat: add model editing capabilities to settings #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add inline editing for custom models with pencil icon button - Prevent duplicate model additions with error messages - Support keyboard shortcuts: Enter to save, Escape to cancel - Disable edit/delete buttons while another model is being edited Deletion of models used by workspaces is safe by design: model selections are stored as strings and passed to providers, so removing a model from settings only removes the shortcut. _Generated with `mux`_
ibetitsmike
force-pushed
the
settings-model-editing
branch
from
4f756ef to
fd91d9f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds inline editing for custom models in the Settings > Models section, with duplicate prevention and a loading state.
Changes
Deletion safety
Deleting a model from settings only removes it from the dropdown—it doesn't invalidate workspace selections. Model strings are stored in localStorage and passed directly to providers, so workspaces keep working until the user changes their selection.
Generated with
mux