Skip to content

Conversation

@ammar-agent
Copy link
Collaborator

@ammar-agent ammar-agent commented Nov 30, 2025

Generated with mux

Summary

Unifies the UX between the model selector dropdown and the Settings pages, with consistent provider icons throughout.

Changes

Models Settings Page

  • Built-in models displayed: Shows all models from KNOWN_MODELS (not just custom models)
  • Favoriting UX: Star icon to set any model as default - same interaction as model selector dropdown
  • Aliases shown: Displays model aliases (e.g., sonnet, haiku) with tooltip explaining /m <alias> usage
  • Custom models first: Custom models section at top for easier access
  • Increased density: More compact UI with smaller padding and gaps

Provider Icons

  • New shared components: ProviderIcon and ProviderWithIcon in src/browser/components/ProviderIcon.tsx
  • Icons in Settings: Both Models and Providers sections now show provider icons
  • New icons added: Google (Gemini) and xAI
  • Consistent styling: All icons use currentColor for proper theme support
  • Documentation: Added src/browser/assets/icons/README.md with instructions for adding new icons

Code Organization

  • Extracted ModelRow into separate component for reusability
  • Refactored ModelDisplay to use shared ProviderIcon
  • Removed duplicate icon rendering logic

Icon Sources

Provider Source
Anthropic anthropic.com/brand
OpenAI openai.com/brand
Google Wikimedia Commons
xAI Wikimedia Commons
AWS AWS Architecture Icons

- Show built-in models (from KNOWN_MODELS) in Settings → Models section
- Add favoriting UX (star icon) to set default model from settings
- Display model aliases for built-in models (e.g., /sonnet, /haiku)
- Maintain edit/delete actions only for custom models
- Unified styling between built-in and custom model rows
…d density

- Aliases now shown without '/' prefix with tooltip explaining '/m <alias>' usage
- Custom Models section moved to top for easier access
- Increased UI density: smaller padding, font sizes, and gaps
- Simplified empty state (no message when no custom models)
- Create ProviderIcon component for rendering provider icons
- Create ProviderWithIcon component combining icon + name
- Use ProviderWithIcon in ModelRow for visual consistency
- Update ModelDisplay to use shared ProviderIcon
- Icons gracefully omitted for unrecognized providers
- xAI SVG: cropped viewBox to content bounds (was full page size)
- Google SVG: simplified to monochrome, kept original path data
- Both now include source URL comments for attribution
@ammario
Copy link
Member

ammario commented Nov 30, 2025

Shows built-in models in the models page:

image

also adds provider icons for easier scanning

@ammario ammario merged commit b25b572 into main Nov 30, 2025
13 checks passed
@ammario ammario deleted the unify-model-selector-settings-ux branch November 30, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants