🤖 fix: use atomic writes for partial.json to prevent corruption #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
fix-malformed-json-partial
branch
from
94e4b01 to
1e4549d
Compare
Non-atomic fs.writeFile can leave truncated/malformed JSON if the app crashes mid-write. This causes 'Unexpected end of JSON input' errors when reading partial.json on the next stream start, leading to amnesia (messages being lost). Use write-file-atomic which writes to a temp file then renames, ensuring readers always see either the old complete file or the new complete file, never a partial write. Fixed in: - partialService.ts (partial.json) - historyService.ts (chat.jsonl rewrites) - sessionFile.ts (generic session file utility) Fixes #803
ammar-agent
force-pushed
the
fix-malformed-json-partial
branch
from
d938038 to
f9846c0
Compare
ammario
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-atomic
fs.writeFilecan leave truncated/malformed JSON if the app crashes mid-write. This causes 'Unexpected end of JSON input' errors when reading partial.json on the next stream start, leading to amnesia (messages being lost).Use
write-file-atomicwhich writes to a temp file then renames, ensuring readers always see either the old complete file or the new complete file, never a partial write.Fixed in:
partialService.ts(partial.json)historyService.ts(chat.jsonl rewrites)sessionFile.ts(generic session file utility)Fixes #803
Generated with
mux