🤖 feat: add Solarized light/dark themes with dropdown selector #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend ThemeMode to include solarized-light and solarized-dark - Add THEME_OPTIONS constant for dropdown labels - Create ThemeSelector dropdown component - Update GeneralSection settings to use dropdown instead of toggle - Add complete CSS variables for both Solarized themes - Update command palette to show all theme options - Fix syntax highlighting to treat solarized-light as light theme _Generated with mux_
This comment has been minimized.
This comment has been minimized.
Member
|
wonder if we could easily support VS Code themes and reuse their library. Also just to make sure, we're not increasing the Storybook here? scared about having to review NxM stories on visual changes. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Solarized Light and Solarized Dark themes, and converts the theme toggle button to a dropdown selector.
Changes
ThemeModetype to includesolarized-lightandsolarized-darkTHEME_OPTIONSconstant with labels for dropdownThemeSelectordropdown componentGenerated with
mux