From 4377e8d5d655dd4e72923666ecb1ead1aaac7073 Mon Sep 17 00:00:00 2001
From: Ammar Bandukwala <ammar@ammar.io>
Date: Tue, 7 Oct 2025 15:22:18 -0500
Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20Remove=20unnecessary=20DMG=20sig?=
 =?UTF-8?q?ning=20and=20split=20artifacts?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Remove dmg.sign: true (not needed and discouraged per electron-builder docs)
- Split macOS artifacts into separate x64 and arm64 uploads
- The .app bundle signing is what matters, not the DMG itself

_Generated with `cmux`_
---
 .github/workflows/build.yml | 14 +++++++++++---
 package.json                |  3 ---
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 3af473ad0..ef5eb17ed 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -36,11 +36,19 @@ jobs:
           fi
           bun run dist:mac
 
-      - name: Upload macOS DMG
+      - name: Upload macOS DMG (x64)
         uses: actions/upload-artifact@v4
         with:
-          name: macos-dmg
-          path: release/*.dmg
+          name: macos-dmg-x64
+          path: release/*-x64.dmg
+          retention-days: 30
+          if-no-files-found: error
+
+      - name: Upload macOS DMG (arm64)
+        uses: actions/upload-artifact@v4
+        with:
+          name: macos-dmg-arm64
+          path: release/*-arm64.dmg
           retention-days: 30
           if-no-files-found: error
 
diff --git a/package.json b/package.json
index db5f39594..c669ddc66 100644
--- a/package.json
+++ b/package.json
@@ -118,9 +118,6 @@
       "entitlements": "build/entitlements.mac.plist",
       "entitlementsInherit": "build/entitlements.mac.plist"
     },
-    "dmg": {
-      "sign": true
-    },
     "linux": {
       "target": "AppImage",
       "category": "Development",