🤖 fix: prevent duplicate updater IPC handler registration on window recreate #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
1. Added guard to prevent duplicate updater IPC handler registration
when createWindow() is called again after closing all windows.
2. Added try/catch error handling to the app.on('activate') handler
so errors during window recreation are shown to the user instead
of being silently swallowed.
_Generated with mux_
ammar-agent
force-pushed
the
user-reported-bug-fix
branch
from
5494456 to
c527af6
Compare
ammario
pushed a commit
that referenced
this pull request
Dec 3, 2025
## Summary Add comprehensive E2E tests covering window lifecycle, IPC robustness, streaming edge cases, persistence, and error display. These tests target recent regression patterns. ## Recent Regressions Addressed | Regression | Test Coverage | |------------|---------------| | `MockBrowserWindow.isDestroyed()` (#863) | IPC stability tests verify no crashes during heavy IPC | | IPC send to destroyed window (#859) | `ipcRobustness.spec.ts` - concurrent IPC operations | | Duplicate IPC handler registration (#851) | `windowLifecycle.spec.ts` - rapid IPC calls test | | Stream error handling (#880) | `streamEdgeCases.spec.ts` + `errorDisplay.spec.ts` | ## New Test Files (26 tests total) - **windowLifecycle.spec.ts** (6 tests): window operations, IPC stability under load - **ipcRobustness.spec.ts** (4 tests): concurrent IPC calls, state preservation - **streamEdgeCases.spec.ts** (6 tests): streaming during UI operations, error scenarios - **persistence.spec.ts** (4 tests): chat history, settings, mode persistence - **errorDisplay.spec.ts** (6 tests): error messages display, recovery flows ## Infrastructure Changes - **Error mock scenarios**: rate limit, server error, network error scenarios - **Stream timeline capture**: now handles `stream-error` events (previously only `stream-end`) - **CI matrix**: Linux (comprehensive, 47 tests) + macOS (window lifecycle, 6 tests) ## CI Configuration ```yaml matrix: include: - os: linux # Comprehensive E2E tests - os: macos # Window lifecycle tests only (platform-dependent) ``` _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a window is recreated (e.g., clicking dock icon on macOS after closing all windows),
createWindow()was trying to register the same IPC handlers again, causing the error:Added a guard flag matching the pattern already used by
ipcMain.register().Generated with
mux