Skip to content

🤖 fix: skip splash screen on macOS dock reactivation #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammario merged 1 commit into from
Dec 2, 2025
Merged

🤖 fix: skip splash screen on macOS dock reactivation #854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions src/desktop/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,27 +557,9 @@ if (gotTheLock) {
});

app.on("activate", () => {
// Only create window if app is ready and no window exists
// This prevents "Cannot create BrowserWindow before app is ready" error
// Skip splash on reactivation - services already loaded, window creation is fast
if (app.isReady() && mainWindow === null) {
void (async () => {
try {
await showSplashScreen();
await loadServices();
createWindow();
} catch (error) {
console.error(`[${timestamp()}] Failed to recreate window:`, error);
closeSplashScreen();

const errorMessage =
error instanceof Error ? `${error.message}\n\n${error.stack ?? ""}` : String(error);

dialog.showErrorBox(
"Window Creation Failed",
`Failed to recreate the application window:\n\n${errorMessage}`
);
}
})();
createWindow();
}
});
}