🤖 fix: prevent Windows bash windows from stealing focus #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, when spawning bash processes (via Git Bash or WSL), the default behavior creates visible console windows that steal focus. Add windowsHide: true to all spawn() calls that run background bash or ssh processes. This prevents the console windows from appearing. The terminal service spawn calls intentionally remain visible since they're meant to open user-facing terminal windows. Fixed locations: - LocalBaseRuntime.ts: exec() and runInitHook() - bashExecutionService.ts: executeStreaming() - SSHRuntime.ts: exec(), execSSHCommand(), and bundle creation _Generated with mux_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when spawning bash processes (via Git Bash or WSL), the
default behavior creates visible console windows that steal focus.
Add
windowsHide: trueto allspawn()calls that run background bashor ssh processes. This prevents the console windows from appearing.
The terminal service spawn calls intentionally remain visible since
they're meant to open user-facing terminal windows.
Fixed locations:
LocalBaseRuntime.ts: exec() and runInitHook()bashExecutionService.ts: executeStreaming()SSHRuntime.ts: exec(), execSSHCommand(), and bundle creationGenerated with
mux