🤖 fix: restore workspace name truncation in sidebar #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar-agent
force-pushed
the
fix-sidebar-workspace-truncation
branch
8 times, most recently
from
86f2953 to
658dd87
Compare
The TooltipWrapper component added in cf61afe was missing min-w-0 in inline mode, which broke the flex truncation chain. Long workspace names caused the sidebar to become horizontally scrollable instead of properly truncating. Changes: - Added min-w-0 to TooltipWrapper inline mode to preserve truncation - Replaced flexbox with CSS Grid (grid-cols-[auto_1fr_auto]) for the workspace row - this guarantees the middle column truncates properly without complex nested flex chains - Added LongWorkspaceNames story with git status indicators to catch future truncation regressions - Default createdAt to Date.now() in mockFactory to prevent workspaces from being hidden by age filters _Generated with mux_
ammar-agent
force-pushed
the
fix-sidebar-workspace-truncation
branch
from
658dd87 to
4e06909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TooltipWrapper component added in cf61afe was missing
min-w-0in inline mode, which broke the flex truncation chain. Long workspace names caused the sidebar to become horizontally scrollable instead of properly truncating.Changes:
min-w-0to TooltipWrapper inline mode to preserve truncationgrid-cols-[auto_1fr_auto]) for the workspace row - this guarantees the middle column truncates properly without complex nested flex chainsLongWorkspaceNamesstory with git status indicators to catch future truncation regressionscreatedAttoDate.now()in mockFactory to prevent workspaces from being hidden by age filters in storiesGenerated with
mux