From 3470a4d739f8565898efb78e74259a543439e515 Mon Sep 17 00:00:00 2001 From: Steven Masley Date: Wed, 27 Aug 2025 09:47:29 -0500 Subject: [PATCH] chore: remove invalid field It is an alloy field, not a grafana agent one --- README.md | 3 +-- coder-observability/Chart.lock | 6 +++--- coder-observability/templates/_collector-config.tpl | 1 - coder-observability/values.yaml | 2 -- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 9a77d7d..855c5f3 100644 --- a/README.md +++ b/README.md @@ -261,11 +261,10 @@ values which are defined [here](https://github.com/grafana/helm-charts/tree/main | global.externalZone | string | `"svc.cluster.local"` | | | global.postgres | object | `{"alerts":{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}},"database":"coder","exporter":{"image":"quay.io/prometheuscommunity/postgres-exporter"},"hostname":"localhost","mountSecret":"secret-postgres","password":null,"port":5432,"sslmode":"disable","sslrootcert":null,"username":"coder","volumeMounts":[],"volumes":[]}` | postgres connection information NOTE: these settings are global so we can parameterise some values which get rendered by subcharts | | global.postgres.alerts | object | `{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}}` | alerts for postgres | -| global.telemetry | object | `{"metrics":{"scrape_interval":"15s","scrape_timeout":"12s"},"profiling":{"delta_profiling_duration":"30s","scrape_interval":"60s","scrape_timeout":"70s"}}` | control telemetry collection | +| global.telemetry | object | `{"metrics":{"scrape_interval":"15s","scrape_timeout":"12s"},"profiling":{"scrape_interval":"60s","scrape_timeout":"70s"}}` | control telemetry collection | | global.telemetry.metrics | object | `{"scrape_interval":"15s","scrape_timeout":"12s"}` | control metric collection | | global.telemetry.metrics.scrape_interval | string | `"15s"` | how often the collector will scrape discovered pods | | global.telemetry.metrics.scrape_timeout | string | `"12s"` | how long a request will be allowed to wait before being canceled | -| global.telemetry.profiling.delta_profiling_duration | string | `"30s"` | duration of each pprof profiling capture, must be less than scrape_interval | | global.telemetry.profiling.scrape_interval | string | `"60s"` | how often the collector will scrape pprof endpoints | | global.telemetry.profiling.scrape_timeout | string | `"70s"` | how long a request will be allowed to wait before being canceled | | global.zone | string | `"svc"` | | diff --git a/coder-observability/Chart.lock b/coder-observability/Chart.lock index e72a227..08b749e 100644 --- a/coder-observability/Chart.lock +++ b/coder-observability/Chart.lock @@ -1,7 +1,7 @@ dependencies: - name: pyroscope repository: https://grafana.github.io/helm-charts - version: 1.14.1 + version: 1.14.2 - name: grafana repository: https://grafana.github.io/helm-charts version: 7.3.12 @@ -14,5 +14,5 @@ dependencies: - name: grafana-agent repository: https://grafana.github.io/helm-charts version: 0.37.0 -digest: sha256:5a5f27f74bbf34848da9c1bab508d3b33fda19789016c2eda9608dcd6373921d -generated: "2025-08-04T13:28:59.433447595-05:00" +digest: sha256:38b7d46261c4d39a103fbf61eac9da26a997024221ab81078ea5b34fc2b83c68 +generated: "2025-08-27T07:53:21.79582734-05:00" diff --git a/coder-observability/templates/_collector-config.tpl b/coder-observability/templates/_collector-config.tpl index 6a07a89..1e3e4e7 100644 --- a/coder-observability/templates/_collector-config.tpl +++ b/coder-observability/templates/_collector-config.tpl @@ -210,7 +210,6 @@ pyroscope.scrape "pods" { scrape_interval = "{{ .Values.global.telemetry.profiling.scrape_interval }}" scrape_timeout = "{{ .Values.global.telemetry.profiling.scrape_timeout }}" - delta_profiling_duration = "{{ .Values.global.telemetry.profiling.delta_profiling_duration }}" clustering { enabled = true diff --git a/coder-observability/values.yaml b/coder-observability/values.yaml index 548195f..0ae9d28 100644 --- a/coder-observability/values.yaml +++ b/coder-observability/values.yaml @@ -118,8 +118,6 @@ global: scrape_interval: 60s # global.telemetry.profiling.scrape_timeout -- how long a request will be allowed to wait before being canceled scrape_timeout: 70s - # global.telemetry.profiling.delta_profiling_duration -- duration of each pprof profiling capture, must be less than scrape_interval - delta_profiling_duration: 30s # global.postgres -- postgres connection information # NOTE: these settings are global so we can parameterise some values which get rendered by subcharts