From 3cda214db36c91c6c7b0577de94289f8fc1f8df2 Mon Sep 17 00:00:00 2001 From: Michael Suchacz <203725896+ibetitsmike@users.noreply.github.com> Date: Thu, 20 Nov 2025 18:50:59 +0100 Subject: [PATCH 1/2] fix(coder/modules/mux): skipping post install scripts that cause module flakiness --- registry/coder/modules/mux/README.md | 12 ++++++------ registry/coder/modules/mux/main.test.ts | 3 ++- registry/coder/modules/mux/run.sh | 3 ++- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/registry/coder/modules/mux/README.md b/registry/coder/modules/mux/README.md index 9bd85e20c..e6132ea6b 100644 --- a/registry/coder/modules/mux/README.md +++ b/registry/coder/modules/mux/README.md @@ -14,7 +14,7 @@ Automatically install and run mux in a Coder workspace. By default, the module i module "mux" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/mux/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.example.id } ``` @@ -35,7 +35,7 @@ module "mux" { module "mux" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/mux/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.example.id } ``` @@ -46,7 +46,7 @@ module "mux" { module "mux" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/mux/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.example.id # Default is "latest"; set to a specific version to pin install_version = "0.4.0" @@ -59,7 +59,7 @@ module "mux" { module "mux" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/mux/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.example.id port = 8080 } @@ -73,7 +73,7 @@ Run an existing copy of mux if found, otherwise install from npm: module "mux" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/mux/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.example.id use_cached = true } @@ -87,7 +87,7 @@ Run without installing from the network (requires mux to be pre-installed): module "mux" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/mux/coder" - version = "1.0.0" + version = "1.0.1" agent_id = coder_agent.example.id install = false } diff --git a/registry/coder/modules/mux/main.test.ts b/registry/coder/modules/mux/main.test.ts index efc00460d..96fae5e4d 100644 --- a/registry/coder/modules/mux/main.test.ts +++ b/registry/coder/modules/mux/main.test.ts @@ -55,6 +55,7 @@ describe("mux", async () => { expect(output.exitCode).toBe(0); const expectedLines = [ "📦 Installing mux via npm into /tmp/mux...", + "⏭️ Skipping npm lifecycle scripts with --ignore-scripts", "🥳 mux has been installed in /tmp/mux", "🚀 Starting mux server on port 4000...", "Check logs at /tmp/mux.log!", @@ -62,5 +63,5 @@ describe("mux", async () => { for (const line of expectedLines) { expect(output.stdout).toContain(line); } - }, 60000); + }, 180000); }); diff --git a/registry/coder/modules/mux/run.sh b/registry/coder/modules/mux/run.sh index c202a9ee0..9c4a6d8cc 100644 --- a/registry/coder/modules/mux/run.sh +++ b/registry/coder/modules/mux/run.sh @@ -50,13 +50,14 @@ if [ ! -f "$MUX_BINARY" ] || [ "${USE_CACHED}" != true ]; then if [ ! -f package.json ]; then echo '{}' > package.json fi + echo "⏭️ Skipping npm lifecycle scripts with --ignore-scripts" PKG="mux" if [ -z "${VERSION}" ] || [ "${VERSION}" = "latest" ]; then PKG_SPEC="$PKG@latest" else PKG_SPEC="$PKG@${VERSION}" fi - if ! npm install --no-audit --no-fund --omit=dev "$PKG_SPEC"; then + if ! npm install --no-audit --no-fund --omit=dev --ignore-scripts "$PKG_SPEC"; then echo "❌ Failed to install mux via npm" exit 1 fi From 11a6a40382adbcc320c409c2a166cce96dde734e Mon Sep 17 00:00:00 2001 From: Michael Suchacz <203725896+ibetitsmike@users.noreply.github.com> Date: Thu, 20 Nov 2025 18:55:50 +0100 Subject: [PATCH 2/2] chore: bump module versions (patch)