Add alternativeWebUrl param#956
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9e8beed19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
EhabY
reviewed
May 18, 2026
EhabY
left a comment
EhabY
left a comment
Collaborator
There was a problem hiding this comment.
Nice improvement. Make sure to run pnpm format and pnpm lint:fix/pnpm typecheck!
EhabY
reviewed
May 18, 2026
ibdafna
force-pushed
the
nflx/support-alternative-web-url
branch
from
5f34410 to
fc18726
Compare
EhabY
reviewed
Jun 2, 2026
…r sub-path deployments and alternative web URLs. Add tests to verify that the path prefix is not doubled and that the correct prefix is swapped based on the alternative web URL configuration.
ibdafna
force-pushed
the
nflx/support-alternative-web-url
branch
from
763017a to
5222afc
Compare
EhabY
reviewed
Jun 8, 2026
- Scope coder.alternativeWebUrl to "application" so a workspace's settings.json cannot override the browser redirect target - Only rebase the OAuth authorization endpoint when it lives under the connection URL, and extract the logic into toBrowserAuthorizationUrl - Build params with URLSearchParams and merge onto the endpoint, so an endpoint that already carries a query string is preserved - Simplify openInBrowser to rely on Uri.joinPath - Make the mock Uri.joinPath collapse seam slashes like vscode-uri - Simplify the new util/authorizer/tasks tests
EhabY
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new parameter for specifying an alternative URL to use when opening Coder pages in the browser. When set, it replaces the connection URL for browser links only (dashboard, workspace pages, token authentication page). The connection URL is still used for API calls, SSH, and CLI operations. Useful when the Coder API runs on a port that browsers restrict (e.g., 7004) but the web UI is accessible on a standard port (e.g., 443)."