feat: add auth telemetry lifecycle traces#994
Open
EhabY wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #984
Validation
pnpm format:checkpnpm lintpnpm typecheckpnpm test:extension ./test/unit/core/cliCredentialManager.test.ts ./test/unit/login/loginCoordinator.test.ts ./test/unit/core/cliManager.test.ts ./test/unit/deployment/deploymentManager.test.ts ./test/unit/instrumentation/auth.test.ts ./test/unit/commands.test.tsImplementation notes
auth.loginspan so command/auto-login/switch-deployment sources and URL-prompt cancellation are captured once.LoginCoordinator.ensureLoggedIn({ traceLogin: false })is only used from that command-owned span to avoid emitting a second direct-login span for the same attempt.Generated by Coder Agents for @EhabY.