Skip to content

feat: add auth telemetry lifecycle traces#994

Open
EhabY wants to merge 2 commits into
mainfrom
feat/auth-telemetry-lifecycle
Open

feat: add auth telemetry lifecycle traces#994
EhabY wants to merge 2 commits into
mainfrom
feat/auth-telemetry-lifecycle

Conversation

@EhabY

@EhabY EhabY commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add auth login/logout outcome traces with bounded source/method/reason properties
  • add credential store/clear traces with keyring mode, credential category, bounded failure category, and duration
  • add deployment suspended/recovered/cross-window/auth-config-recovery-failed lifecycle events
  • add representative command, coordinator, credential, deployment, and auth telemetry tests

Closes #984

Validation

  • pnpm format:check
  • pnpm lint
  • pnpm typecheck
  • pnpm test:extension ./test/unit/core/cliCredentialManager.test.ts ./test/unit/login/loginCoordinator.test.ts ./test/unit/core/cliManager.test.ts ./test/unit/deployment/deploymentManager.test.ts ./test/unit/instrumentation/auth.test.ts ./test/unit/commands.test.ts
Implementation notes
  • Command login owns the outer auth.login span so command/auto-login/switch-deployment sources and URL-prompt cancellation are captured once.
  • LoginCoordinator.ensureLoggedIn({ traceLogin: false }) is only used from that command-owned span to avoid emitting a second direct-login span for the same attempt.
  • Direct coordinator callers, including URI login, keep default login tracing.
  • Credential store/clear events are emitted around the credential manager operations, separate from logout outcome telemetry.

Generated by Coder Agents for @EhabY.

@EhabY EhabY self-assigned this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Telemetry: instrument auth, deployment, and credential lifecycle

1 participant