Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single click opens file in new tab instead of selecting it #194

Closed
csabadm opened this issue Sep 28, 2018 · 7 comments
Closed

Single click opens file in new tab instead of selecting it #194

csabadm opened this issue Sep 28, 2018 · 7 comments

Comments

@csabadm
Copy link

csabadm commented Sep 28, 2018

  • Version : v11.1.0
  • Node Version : v10.11.0
  • OS : Ubuntu 16
  • Browser name/version: Chrome 69.0.3497.100
  • Used Command Line Parameters:
  • Changed Config:

As the tile says sometimes clicking on a file just opens it in a new tab, refreshing a few times solves it sometimes, but after changing directory the problem appears again. I'm accessing cloudcmd over https.

The browser's console displays the following errors:
cloudcmd: sw: install: cloudcmd: Thu Sep 27 2018 18:13:33 GMT+0300 (Eastern European Summer Time)
sw.js:1 Uncaught (in promise) TypeError: Request failed
VM82 cloudcmd.js:1 cloudcmd: sw: updated
currify.js:35 cloudcmd: sw: install: cloudcmd: Thu Sep 27 2018 18:13:33 GMT+0300 (Eastern European Summer Time)
cloudcmd.js:58 cloudcmd: sw: updated
cloudcmd.js:61 Uncaught (in promise) TypeError: window.CloudCmd is not a function
at VM82 cloudcmd.js:1
at Generator.next ()
at n (VM82 cloudcmd.js:1)
at u (VM82 cloudcmd.js:1)
sw.js:1 Uncaught (in promise) TypeError: Request failed


@coderaiser
Copy link
Owner

coderaiser commented Sep 28, 2018

Could you please try to Clear site data in Developer Tools.

screen shot 2018-09-28 at 12 24 20 pm

And reload a page. Is it helps?

Could you reproduce this on one of demo sites: heroku or now?

@csabadm
Copy link
Author

csabadm commented Sep 28, 2018

I tried clearing site data/using Incognito mode but it didn't help.
I can't seem to reproduce it on the demo sites.
Forgot to mention I'm using the prefix and the auth settings, could those cause the problem?

@coderaiser
Copy link
Owner

prefix and auth settings should not cause the problem. Please try to update to v11.2.0 maybe this will fix things up.

@coderaiser
Copy link
Owner

Could you please tell me why do you use prefix?

@csabadm
Copy link
Author

csabadm commented Sep 28, 2018

Found the problem:
Since it was a pain to proxy the request for the favicon.ico i just refused it with 503, turns out not being able to load that messed up something.
It worked fine up to v10.6 or v10.7 without the favicon

@csabadm
Copy link
Author

csabadm commented Sep 28, 2018

As for you question, I run multiple instances of cloudcmd each with a different linux user/port/homedir and I use the prefix to proxy the incoming connection on port 80/443 to the right cloudcmd instance.

@coderaiser
Copy link
Owner

coderaiser commented Sep 28, 2018

Thank you 👍, fixed with 421b860, landed in v11.2.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants