Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git in docker container. #203

Closed
greenfox1505 opened this issue Mar 12, 2019 · 5 comments
Closed

Git in docker container. #203

greenfox1505 opened this issue Mar 12, 2019 · 5 comments
Labels
enhancement Some improvement that isn't a feature

Comments

@greenfox1505
Copy link

I believe Git just be installed by default in the docker container. Git integration is a core feature of VSCode. It's easy to add apt-get install git without significant complication or inflation of the docker image.
@jeasonstudio
Copy link
Contributor

sgtm

@sr229
Copy link
Contributor

sr229 commented Mar 12, 2019

actually there's some inflation but its not detriminal as git itself is very lightweight.

@kylecarbs kylecarbs added the enhancement Some improvement that isn't a feature label Mar 12, 2019
@greenfox1505
Copy link
Author

greenfox1505 commented Mar 12, 2019 •
edited

IMHO it's not significant inflation.

pokemonlover1234 added a commit to pokemonlover1234/code-server that referenced this issue Mar 13, 2019
@pokemonlover1234
Add git to docker container
093c364 
Install git in the docker container, proposed by coder#203. While it is possible that issue requires further discussion, this is just a proposal pull request. If that proposal is accepted, here's the pull request.
@pokemonlover1234 pokemonlover1234 mentioned this issue Mar 13, 2019
Closed
@nhooyr nhooyr mentioned this issue Mar 13, 2019
Merged
nhooyr pushed a commit that referenced this issue Mar 13, 2019
@pokemonlover1234 @nhooyr
Add git to docker container
ec2d01a 
Install git in the docker container, proposed by #203. While it is possible that issue requires further discussion, this is just a proposal pull request. If that proposal is accepted, here's the pull request.
nhooyr added a commit that referenced this issue Mar 13, 2019
@nhooyr
Dockerfile: include git
c8307a7 
Closes #221
Closes #230
Closes #203
@SuperSandro2000
Copy link
Contributor

Maybe it would be a good idea for future additions to add a bare bone image for people like me that wan't to save drive space and a more featured image.
If we base the more featured image on the barer one we could make the building process really easy.

@nhooyr nhooyr mentioned this issue Mar 13, 2019
Closed
@nhooyr
Copy link
Contributor

nhooyr commented Mar 13, 2019

Opened #234

code-asher pushed a commit that referenced this issue Jun 19, 2019
@pokemonlover1234 @nhooyr
Add git to docker container
a22b9c0 
Install git in the docker container, proposed by #203. While it is possible that issue requires further discussion, this is just a proposal pull request. If that proposal is accepted, here's the pull request.
code-asher pushed a commit that referenced this issue Jun 19, 2019
@nhooyr
Dockerfile: include git
3a3df4a 
Closes #221
Closes #230
Closes #203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@greenfox1505 @kylecarbs @SuperSandro2000 @nhooyr @sr229 @jeasonstudio