Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: remove windows/macOS support in favour of using docker #97

Open
nhooyr opened this Issue Mar 7, 2019 · 6 comments

Comments

Projects
None yet
6 participants
@nhooyr
Copy link
Collaborator

nhooyr commented Mar 7, 2019

Will make our CI/testing/code simpler.

Docker should be enough for pretty much every use case I can think of anyway, aside from developing windows apps or macOS apps which code-server doesn't really have good support for anyway.

Not 100% convinced this is the way to go, opening for thoughts.

@kylecarbs @coderasher

@PhilsLab

This comment has been minimized.

Copy link
Contributor

PhilsLab commented Mar 7, 2019

I like this idea. This kind of application has most potential when deployed in a container, also opening a lot of possibilities for Kubernetes.

@Omeryl

This comment has been minimized.

Copy link
Contributor

Omeryl commented Mar 7, 2019

I'm iffy on this because Docker on Mac can be really weird sometimes, how much code would be removable if you removed macOS support?

@kylecarbs

This comment has been minimized.

Copy link
Member

kylecarbs commented Mar 7, 2019

Not much. All the code is pretty generalized.

@orzFly

This comment has been minimized.

Copy link

orzFly commented Mar 8, 2019

Docker on Windows is also really weird.

By the way, installing Docker for Windows enables Hyper-V, which prevents you from being able to use VMWare Workstation or Player. (Although there may be some workarounds, it's weird.

@kylecarbs

This comment has been minimized.

Copy link
Member

kylecarbs commented Mar 8, 2019

This seems to be a split response.

I love the idea of removing platforms in favor of using Docker. I suppose an issue is that code-server wasn't really designed with containment in mind.

@nhooyr nhooyr changed the title Remove windows/macOS support in favour of using docker packaging: remove windows/macOS support in favour of using docker Mar 8, 2019

@NGTmeaty

This comment has been minimized.

Copy link

NGTmeaty commented Mar 8, 2019

Personally, I would much rather more platform support. Docker is annoying to setup on windows and imo shouldn't be forced. If we can compile a binary for it, we might as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.