Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ENTRYPOINT to omit full command at launch. #170

Closed
wants to merge 1 commit into
base: docker
from

Conversation

Projects
None yet
3 participants
@ay-b
Copy link

ay-b commented Mar 9, 2019

Having code-server at the ENTRYPOINT will free the CMD line, so launching that container will no longer require writing the binary name after image name and will not confuse people anymore.

Added ENTRYPOINT to omit full command at launch.
Moving `code-server` to ENTRYPOINT will allow omitting it from the CLI launch.

@ay-b ay-b requested a review from nhooyr as a code owner Mar 9, 2019

@nhooyr
Copy link
Collaborator

nhooyr left a comment

Can you modify the README.md as well to account for this.

You cannot modify the CMD instruction for now until code-server accepts . properly. Exec form CMD's don't expand variables.

Please leave it as it is.

nhooyr added a commit that referenced this pull request Mar 9, 2019

@kylecarbs kylecarbs closed this in f375335 Mar 9, 2019

@ay-b

This comment has been minimized.

Copy link
Author

ay-b commented Mar 9, 2019

I don't know where the agrument logic lives, but at least as a workaround in it to replace " . " with " $PWD " before actual submitting to binary should work. Isn't it?

@nhooyr

This comment has been minimized.

Copy link
Collaborator

nhooyr commented Mar 9, 2019

Sorry, I don't understand. Could you elaborate? Are you asking why . doesn't work?

@ay-b

This comment has been minimized.

Copy link
Author

ay-b commented Mar 9, 2019

Sorry, I don't understand. Could you elaborate? Are you asking why . doesn't work?

I don't know why it doesn't work — didn't see the code, sorry. But replacing the " . " argument with the " $PWD " prior the arguments get worked out should do the trick.

I'm sorry if I'm speaking nonsense.

@nhooyr

This comment has been minimized.

Copy link
Collaborator

nhooyr commented Mar 9, 2019

Ah looks like this was fixed to work now: #19

I will update. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.