Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts parts of my last PR #177

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@nhooyr
Copy link
Collaborator

nhooyr commented Mar 9, 2019

Cannot mount data directory at the moment, we need to make code-server
override all binaries in there instead of reusing and will wait
until the new Dockerfile is pushed before removing the default
entrypoint from README.md

Reverts parts of my last PR
Cannot mount data directory at the moment, we need to make code-server
override all binaries in there instead of reusing and will wait
until the new Dockerfile is pushed before removing the default
entrypoint from README.md

@nhooyr nhooyr requested review from code-asher and kylecarbs as code owners Mar 9, 2019

@kylecarbs kylecarbs merged commit 76e0338 into master Mar 9, 2019

@kylecarbs kylecarbs deleted the anmol branch Mar 9, 2019

andreimc added a commit to devbox-hero/code-server that referenced this pull request Mar 11, 2019

Merge remote-tracking branch 'upstream/master'
* upstream/master: (35 commits)
  Dockerfile: use relative path instead of $PWD for CMD
  Update docker oneliner and fix clone task
  Clone exact vscode release branch when build task (codercom#167)
  Add -t flag to docker example (codercom#181)
  Reverts parts of my last PR (codercom#177)
  Fix build and Dockerfile issues (codercom#176)
  Add nginx reverse proxy guide for selfhosted
  Use a timing-safe equality check for passwords (codercom#133)
  Open websocket on same path as page (codercom#149)
  Adhere to XDG base directory spec for dataDir and logDir (codercom#156)
  Improve github issue template (codercom#162)
  Fix typo: environemnt -> environment (codercom#159)
  Add back web class
  Move upx compression behind an env flag
  ci: enable travis npm cache (codercom#110)
  Improve .dockerignore (codercom#111)
  Feature/1.32.0 update (codercom#117)
  Update grammar on README (codercom#139)
  inital -> initial (codercom#135)
  Handle arch in dockerfile and add PR template (codercom#109)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.