Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another fix for the Dockerfile and build #188

Merged
merged 2 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@nhooyr
Copy link
Collaborator

nhooyr commented Mar 10, 2019

No description provided.

Dockerfile: fix
ENTRYPOINT must be provided in exec form for args
from docker run to be passed correctly.

See https://docs.docker.com/engine/reference/builder/#cmd

@nhooyr nhooyr requested review from code-asher and kylecarbs as code owners Mar 10, 2019

@nhooyr nhooyr force-pushed the anmol branch from a863d1c to 674242f Mar 10, 2019

@avelino
Copy link
Contributor

avelino left a comment

LGTM

@nhooyr nhooyr referenced this pull request Mar 11, 2019

Open

sudo in Dockerfile? #65

@kylecarbs kylecarbs merged commit 03c0bde into master Mar 11, 2019

@kylecarbs kylecarbs deleted the anmol branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.