Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for incorrect password. Fix issue #55 #201

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
4 participants
@Multishifties
Copy link
Contributor

Multishifties commented Mar 11, 2019

Describe in detail the problem you had and how this PR fixes it

Issue:
On initial welcome/login screen of binary, no error message is displayed in the event of an incorrect password. (See #55)

Changes:
Adds simple logic and styling for error display. Currently is of identical styling/design to the coder.com login page.

Test Environment:
OS: Mac OS High Sierra (10.13.6)
Browser: Google Chrome 72.0.3626.109 (Official Build) (64-bit)
(Result: Pass! Compile was successful and everything functions as expected)

Caveats:
None that I can think of at the moment. (I mean, the error message is hard coded. But this page has only one input and the page only has one purpose and does exactly one thing. So I don't know that this is necessarily a bad thing)

@Multishifties

This comment has been minimized.

Copy link
Contributor Author

Multishifties commented Mar 12, 2019

@nhooyr Can you review this PR? I can't request you as a reviewer and Asher and Kyle probably have a backlog that will last for a while.

@nhooyr

This comment has been minimized.

Copy link
Collaborator

nhooyr commented Mar 12, 2019

@kylecarbs why can't he request me as a reviewer?

Show resolved Hide resolved packages/app/browser/src/app.html
Show resolved Hide resolved packages/app/browser/src/app.ts
@nhooyr

nhooyr approved these changes Mar 12, 2019

@avelino
Copy link
Contributor

avelino left a comment

LGTM

@kylecarbs kylecarbs merged commit 0efae1f into codercom:master Mar 12, 2019

@Multishifties Multishifties deleted the Multishifties:fix/password-error-notify branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.