Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate secure passwords, resolves issue #26 #51

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@Multishifties
Copy link
Contributor

Multishifties commented Mar 6, 2019

Issue:
#26

Changes:
Swap out the password generator for a native NodeJS CSPRNG method
https://nodejs.org/dist/latest-v10.x/docs/api/crypto.html#crypto_crypto_randombytes_size_callback

Test Environment:
OS: Mac OS High Sierra (10.13.6)
Browser: Google Chrome 72.0.3626.109 (Official Build) (64-bit)
(Result: Pass! Compile was successful and everything functions as expected)

Caveats:
None that I can think of. Although this did lead me to discover another issue. The input component has no error states for an incorrect password. (I'll open a new issue for this and style it to match what we currently have on our hosted services)
UPDATE: other issue is now here #55

@kylecarbs kylecarbs requested review from nhooyr and removed request for kylecarbs and code-asher Mar 6, 2019

@nhooyr

nhooyr approved these changes Mar 6, 2019

@Multishifties Multishifties force-pushed the Multishifties:fix/issue-26 branch from 9fd1fc2 to b543880 Mar 6, 2019

@Multishifties Multishifties changed the title Generate secure passwords, resolves issue 26 Generate secure passwords, resolves issue #26 Mar 6, 2019

@kylecarbs kylecarbs merged commit e20b79b into codercom:master Mar 7, 2019

@Multishifties Multishifties deleted the Multishifties:fix/issue-26 branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.