Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docker build working with after a fresh checkout #72

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@zerdos
Copy link

zerdos commented Mar 7, 2019

No description provided.

@zerdos zerdos requested review from code-asher and kylecarbs as code owners Mar 7, 2019

@aslafy-z

This comment has been minimized.

Copy link

aslafy-z commented on .dockerignore in 4f0dbd4 Mar 7, 2019

These lines might be replaced by

**/node_modules
@aslafy-z

This comment has been minimized.

Copy link

aslafy-z commented on Dockerfile in 4f0dbd4 Mar 7, 2019

Typo here: frozen

zerdos added some commits Mar 7, 2019

@@ -224,7 +224,7 @@ const ensureCloned = register("vscode:clone", async (runner) => {
}

runner.cwd = vscodePath;
const checkout = await runner.execute("git", ["checkout", "tags/1.31.1"]);
const checkout = await runner.execute("git", ["checkout", "tags/1.31.1"]); //TODO: this tag should come from a parameter

This comment has been minimized.

@kylecarbs

kylecarbs Mar 7, 2019

Member

What do you mean by a parameter?

This comment has been minimized.

@nhooyr

nhooyr Mar 7, 2019

Collaborator

I guess he means it shouldn't be hard coded.

zerdos added some commits Mar 7, 2019

@zerdos zerdos requested a review from nhooyr as a code owner Mar 7, 2019

@@ -1,4 +1,4 @@
FROM node:8.15.0
FROM node:8.9.3

This comment has been minimized.

@nhooyr

nhooyr Mar 7, 2019

Collaborator

Why the change?

@@ -18,7 +18,7 @@ RUN yarn && yarn task build:server:binary
# We deploy with ubuntu so that devs have a familiar environemnt.
FROM ubuntu:18.10
WORKDIR /root/project
COPY --from=0 /src/packages/server/cli-linux /usr/local/bin/code-server
COPY --from=0 /src/packages/server/cli-linux-x64 /usr/local/bin/code-server

This comment has been minimized.

@nhooyr

nhooyr Mar 7, 2019

Collaborator

afaik, there shouldn't be a -x64 suffix?

@kylecarbs

This comment has been minimized.

@zerdos

zerdos Mar 7, 2019

Author

There should be - that is actually the only output

This comment has been minimized.

@nhooyr

nhooyr Mar 7, 2019

Collaborator

Yup. This was recently changed without me knowing. It's fixed in #109.

@nhooyr

This comment has been minimized.

Copy link
Collaborator

nhooyr commented Mar 7, 2019

I don't understand what this PR fixes. How does docker build . not work after a fresh checkout?

@nhooyr

This comment has been minimized.

Copy link
Collaborator

nhooyr commented Mar 7, 2019

See #72

@nhooyr nhooyr closed this Mar 7, 2019

@zerdos

This comment has been minimized.

Copy link
Author

zerdos commented Mar 7, 2019

This PR makes the Dockerfile actually build without error :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.