Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docker build working with after a fresh checkout #72

Closed
wants to merge 9 commits into from
@@ -1 +1,12 @@
.git
.gitignore
Dockerfile
lib
node_modules
**/dist
**/out
.DS_Store
*.DS_Store
release
**/yarn-error.log
**/node_modules
@@ -4,3 +4,4 @@ dist
out
.DS_Store
release
yarn-error.log
@@ -11,7 +11,7 @@ RUN npm install -g yarn
# directly which should be faster.
WORKDIR /src
COPY . .
RUN yarn
RUN yarn --frozen-lockfile
RUN yarn task build:server:binary

# We deploy with ubuntu so that devs have a familiar environemnt.
@@ -224,7 +224,7 @@ const ensureCloned = register("vscode:clone", async (runner) => {
}

runner.cwd = vscodePath;
const checkout = await runner.execute("git", ["checkout", "tags/1.31.1"]);
const checkout = await runner.execute("git", ["checkout", "tags/1.31.1"]); //TODO: this tag should come from a parameter

This comment has been minimized.

Copy link
@kylecarbs

kylecarbs Mar 7, 2019

Member

What do you mean by a parameter?

This comment has been minimized.

Copy link
@nhooyr

nhooyr Mar 7, 2019

Collaborator

I guess he means it shouldn't be hard coded.

if (checkout.exitCode !== 0) {
throw new Error(`Failed to checkout: ${checkout.stderr}`);
}
@@ -6,8 +6,8 @@
"description": "Run VS Code remotely.",
"scripts": {
"build:rules": "cd ./rules && tsc -p .",
"packages:install": "cd ./packages && yarn",
"postinstall": "npm-run-all --parallel packages:install build:rules",
"packages:install": "cd ./packages && yarn --frozen-lockfile",
"postinstall": "npm-run-all packages:install build:rules",
"start": "cd ./packages/server && yarn start",
"task": "ts-node -r tsconfig-paths/register build/tasks.ts",
"test": "cd ./packages && yarn test"

Large diffs are not rendered by default.

Oops, something went wrong.
@@ -2,12 +2,12 @@
"name": "@coder/app-common",
"main": "src/app.ts",
"dependencies": {
"material-components-web": "^0.44.0",
"react": "^16.8.1",
"react-dom": "^16.8.1"
"material-components-web": "^0.44.1",
"react": "^16.8.4",
"react-dom": "^16.8.4"
},
"devDependencies": {
"@types/react": "^16.8.2",
"@types/react-dom": "^16.8.0"
"@types/react": "^16.8.7",
"@types/react-dom": "^16.8.2"
}
}

Large diffs are not rendered by default.

Oops, something went wrong.
Oops, something went wrong.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.