Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the en_US.UTF-8 locale in the docker image #84

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@xMrWhite
Copy link

xMrWhite commented Mar 7, 2019

Fixes issues when working with utf-8 text from the command line

close #83

Generate the en_US.UTF-8 locale in the docker image
Fixes issues when working with utf-8 text from the command line

@xMrWhite xMrWhite requested review from code-asher and kylecarbs as code owners Mar 7, 2019

@kylecarbs kylecarbs requested review from nhooyr and removed request for kylecarbs and code-asher Mar 7, 2019

@nhooyr
Copy link
Collaborator

nhooyr left a comment

Appreciate the fix, thanks.

@@ -19,6 +19,8 @@ FROM ubuntu:18.10
RUN apt-get update
RUN apt-get install -y openssl
RUN apt-get install -y net-tools
RUN apt-get install -y locales
RUN locale-gen en_US.UTF-8

This comment has been minimized.

@nhooyr

nhooyr Mar 7, 2019

Collaborator

You'll also need

# We unfortunately cannot use update-locale because docker will not use the env variables
# configured in /etc/default/locale so we need to set it manually.
ENV LANG=en_US.UTF-8
@nhooyr

This comment has been minimized.

Copy link
Collaborator

nhooyr commented Mar 7, 2019

If you don't mind, I'll take this over to get this out quicker. Will credit you in my PR.

nhooyr added a commit to nhooyr/code-server that referenced this pull request Mar 7, 2019

nhooyr added a commit to nhooyr/code-server that referenced this pull request Mar 7, 2019

nhooyr added a commit to nhooyr/code-server that referenced this pull request Mar 7, 2019

@nhooyr nhooyr closed this in #98 Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.