Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example docker command port bind options #88

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
4 participants
@Omeryl
Copy link
Contributor

Omeryl commented Mar 7, 2019

The existing command errors out with

docker: invalid publish opts format (should be name=value but got 'localhost:8443:8443').

it needs to explicitly use an IP and not a hostname.

update example docker command port bind options
must use 127.0.0.1 and not `localhost`

@Omeryl Omeryl requested review from code-asher and kylecarbs as code owners Mar 7, 2019

@Omeryl

This comment has been minimized.

Copy link
Contributor Author

Omeryl commented Mar 7, 2019

CI failing is unrelated, given it's only updating a markdown file.

@kylecarbs kylecarbs requested review from nhooyr and removed request for kylecarbs and code-asher Mar 7, 2019

@coadler

coadler approved these changes Mar 7, 2019

@nhooyr

nhooyr approved these changes Mar 7, 2019

@kylecarbs kylecarbs merged commit 8e68411 into codercom:master Mar 7, 2019

@coadler

This comment has been minimized.

Copy link
Collaborator

coadler commented Mar 7, 2019

@kylecarbs this also needs to be fixed on the homepage

@Omeryl Omeryl deleted the Omeryl:patch-1 branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.