Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: cleanup and add en_US.UTF-8 locale #98

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@nhooyr
Copy link
Collaborator

nhooyr commented Mar 7, 2019

Closes #84
Closes #83

Thanks @xMrWhite, @frol and @sr229.

@nhooyr nhooyr requested review from code-asher and kylecarbs as code owners Mar 7, 2019

@nhooyr nhooyr force-pushed the nhooyr:docker branch from 2f53c6d to fba3fe5 Mar 7, 2019

@nhooyr

This comment has been minimized.

Copy link
Collaborator Author

nhooyr commented Mar 7, 2019

CI failures are related to rate limits so merging this anyway. @kylecarbs is this a known issue?

@nhooyr nhooyr merged commit 14f1230 into codercom:master Mar 7, 2019

@nhooyr nhooyr deleted the nhooyr:docker branch Mar 7, 2019

@kylecarbs

This comment has been minimized.

Copy link
Member

kylecarbs commented Mar 7, 2019

Yup its known. I've attempted to find a good solution. Might need to jank within the CI.

@Omeryl

This comment has been minimized.

Copy link
Contributor

Omeryl commented Mar 7, 2019

@kylecarbs Unrelated to this issue, but I didn't see another one referencing that problem:

Have you tried using travis-ci's caching mechanism? It'd reduce the number of calls your throwing to NPM I believe.

https://docs.travis-ci.com/user/caching/ is the full documentation.

It is generally as simple as adding this to your ci file: cache: npm.

@kylecarbs

This comment has been minimized.

Copy link
Member

kylecarbs commented Mar 7, 2019

Hmm. Will add this. Thanks @Omeryl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.