Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up直近のイベント情報を格納するDBスキーマの定義 #287
Conversation
AnaTofuZ
requested review from
yasulab and
nalabjp
Mar 16, 2018
yasulab
changed the title from
直近のイベント情報を格納するDBschemeの定義
to
直近のイベント情報を格納するDBスキーマの定義
Mar 16, 2018
This comment has been minimized.
This comment has been minimized.
@AnaTofuZ 「未来のイベント」だと10年後とか20年後とかも意味合いとしては含まれてしまうから、今回の文脈では |
This comment has been minimized.
This comment has been minimized.
|
@yasulab なるほど |
AnaTofuZ
changed the title from
直近のイベント情報を格納するDBスキーマの定義
to
[WIP]直近のイベント情報を格納するDBスキーマの定義
Mar 16, 2018
AnaTofuZ
changed the title from
[WIP]直近のイベント情報を格納するDBスキーマの定義
to
直近のイベント情報を格納するDBスキーマの定義
Mar 16, 2018
This comment has been minimized.
This comment has been minimized.
|
@yasulab 名前を |
This comment has been minimized.
This comment has been minimized.
|
@AnaTofuZ FutureEvents から UpcomingEvents に変更されたコミットのログって残しておく必要ありますかね...? |
This comment has been minimized.
This comment has been minimized.
|
確かに結果的にはいらないですね…!!Squashしてみます |
This comment has been minimized.
This comment has been minimized.
|
特に今回の場合、PR内でマイグレーションが完結しているので、Squash しちゃった方が後からコミットログを見る人に親切そうです |
db/schema.rb
Outdated
| @@ -61,6 +61,24 @@ | ||
| t.index ["region"], name: "index_prefectures_on_region" | ||
| end | ||
| create_table "recently_events", force: :cascade do |t| |
This comment has been minimized.
This comment has been minimized.
AnaTofuZ
force-pushed the
create_feature_events_table
branch
Mar 19, 2018
This comment has been minimized.
This comment has been minimized.
|
使っていないテーブルの削除と過去のcommitをSquash してみました |
This comment has been minimized.
This comment has been minimized.
|
@AnaTofuZ Typo
|
This comment has been minimized.
This comment has been minimized.
|
上記の Typo 以外は問題なさそうです! Typo 修正したらマージしちゃいますね ;) |
AnaTofuZ
force-pushed the
create_feature_events_table
branch
to
8e716cb
Mar 19, 2018
This comment has been minimized.
This comment has been minimized.
|
typo修正しました |
yasulab
merged commit 29f24fb
into
master
Mar 19, 2018
This comment has been minimized.
This comment has been minimized.
|
マージしました! |
yasulab
deleted the
create_feature_events_table
branch
Mar 19, 2018
This comment has been minimized.
This comment has been minimized.
|
ありがとうございます! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
AnaTofuZ commentedMar 16, 2018
•
edited by yasulab
背景
eventsを作るに辺り直近のイベント情報が欲しい関連PR: #277
やること
be rails g migration CreateFutureEvents dojo_event_service_id:integer event_id:string event_url:string evented_ad:datetime今回は未来のイベントなのでFutureEventsとして定義していますその後名前を
FutureからUpcomingに修正しました