#2350: It's now possible to render scenes without any blend lights

codereader · Aug 20, 2022 · 2983b80 · 2983b80
1 parent 2ce021b
commit 2983b80
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/radiantcore/rendersystem/backend/BlendLight.cpp b/radiantcore/rendersystem/backend/BlendLight.cpp
@@ -79,10 +79,6 @@ void BlendLight::draw(OpenGLState& state, RenderStateFlags globalFlagsMask,
             // The light textures will be bound by applyState.
             // The texture0/texture1 units will have already been filled in when constructing the pass
 
-            // TODO: Set clamp
-            // glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_BORDER);
-            // glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_BORDER);
-
             // Apply our state to the current state object
             pass.applyState(state, globalFlagsMask);
 

diff --git a/radiantcore/rendersystem/backend/LightingModeRenderer.cpp b/radiantcore/rendersystem/backend/LightingModeRenderer.cpp
@@ -274,6 +274,8 @@ void LightingModeRenderer::drawInteractingLights(OpenGLState& current, RenderSta
 void LightingModeRenderer::drawBlendLights(OpenGLState& current, RenderStateFlags globalFlagsMask,
     const IRenderView& view, std::size_t renderTime)
 {
+    if (_blendLights.empty()) return;
+
     // Set the openGL state
     auto blendLightState = OpenGLShaderPass::CreateBlendLightState(_blendLightProgram);