Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IQM format support into lib/picomodel #17

Merged
merged 1 commit into from Aug 22, 2021

Conversation

illwieckz
Copy link
Contributor

This is a combination of 2 commits.

See TTimo/GtkRadiant#668
and https://gitlab.com/xonotic/netradiant/-/merge_requests/184


@eukara said on GtkRadiant PR:

This adds support for the InterQuake Model format that engines such as ioQuake3, FTE QuakeWorld and many more support.
Animations are not supported (just like most other included model formats) so it'll only load the base pose.

@eukara also said on #radiant @ QuakeNet IRC:

I want to get away from having to maintain this and get it into mainline editors.

The code is ported from WorldSpawn (Radiant fork): https://github.com/VeraVisions/worldspawn

It got merged in GtkRadiant and it replaced the previous radiant-only iqmmodel plugin in NetRadiant.

darkradiant iqm model

darkradiant iqm model

This is a combination of 2 commits.

- add IQM format support into lib/picomodel
  TTimo/GtkRadiant@3408871
- Merge illwieckz their portability fix
  TTimo/GtkRadiant@be993ad

See TTimo/GtkRadiant#668
and https://gitlab.com/xonotic/netradiant/-/merge_requests/184
@illwieckz
Copy link
Contributor Author

See http://sauerbraten.org/iqm/ for information about the InterQuake Model format.

the IQM format is a skeletal model format sharing features with md5mesh/md5anim, with the ability to pack mesh and animation into one .iqm file (a repository-friendly .iqe text-based format also exists but this PR only add support for .iqm).

IQM gets supported by many open source games as a format of choice for skeletal models, often converted to iqm or iqe from md5mesh/md5anim models.

@illwieckz
Copy link
Contributor Author

I have noticed DarkRadiant also has a MD5 animation viewer. This IQM picomodel plugin will not load animations, but this is fine.

If one day someone wants to support IQM in DarkRadiant animation viewer, maybe another route would be to port the iqmmodel NetRadiant plugin that was deleted in NetRadiant in favor of that IQM picomodel plugin (see netradiant@a5c61fb). NetRadiant deleted that iqmmodel plugin because the picomodel library is also used with the q3map2 map compiler so removing the radiant-only iqmmodel plugin prevented to have two iqm plugins in NetRadiant tree. But since DarkRadiant does not ship the q3map2 map compiler porting the iqmmodel plugin would be a viable option before implementing animation parsing to it.

Anyway, for now the IQM picomodel plugin is very fine and is on par with GtkRadiant and NetRadiant level editor, which is very good and make sure the support is the same everywhere and would make very easy to exchange patches across trees if needed, so it's better to stick on picomodel plugin for now and only investigate something else in the future if the need is expressed.

@codereader
Copy link
Owner

Sorry, didn't look at the pull requests so far due to other projects, didn't want to leave you waiting without any reaction.

@codereader
Copy link
Owner

But if you don't mind, could you please open a corresponding bug tracker entry for this pull request? I'm using that one as change log for the releases.

@illwieckz
Copy link
Contributor Author

Right! And don't worry, I'm like super patient. 😁

I'll also create a ticket for the other PR about trailing white space as well. 🙂

@illwieckz
Copy link
Contributor Author

See https://bugs.thedarkmod.com/view.php?id=5712 for sidecar ticket in bug tracker.

@codereader codereader merged commit a333122 into codereader:master Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants