Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation of snapshotting (git add, git commit) arrives too early #69

Closed
bast opened this issue May 15, 2018 · 3 comments
Closed

Explanation of snapshotting (git add, git commit) arrives too early #69

bast opened this issue May 15, 2018 · 3 comments

Comments

@bast
Copy link
Member

bast commented May 15, 2018

We discuss advantages of two-steps snapshotting before we even started to git init and record anything. I think we should start using it and clarify later.

@rkdarst rkdarst mentioned this issue May 29, 2018
9 tasks
@rkdarst
Copy link
Member

rkdarst commented May 31, 2018

Can the whole detailed description of the staging area be left until the dedicated section on it? I think it's not necessary to go into details at the beginning, let's just pretend it is svn-like.

option 1: Not much actually changes, just teach add + commit in sequence without going deep into it. Some explanations can be simplified and the sequence of commands can be hand-waved until later. It would be OK to say "we are staging these for commit and we will talk about this later".

option 2: go all in and don't use git add in first parts (except to track files), use git commit to make commits. Explanations get simpler most of the time, as long as you don't do get in weird states. Usage seems more streamlined. Then present the extra use of git add in the section on staging. We are teaching slightly worse practices at the beginning, but make it simpler. Also git sort of assumes that people use the staging area, and it is hard to fully hide it.

I think option 1 is best because it's the least change, least surprise, etc.

@bast
Copy link
Member Author

bast commented May 31, 2018

I also tend towards 1. Perhaps show an easy to understand small benefit early and definitely postpone diving into more details and more benefits to later.

@bast
Copy link
Member Author

bast commented Jun 8, 2018

I believe this is now solved. There is a mini explanation but all the rest has moved to later.

@bast bast closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants