Skip to content
This repository was archived by the owner on Nov 8, 2022. It is now read-only.

Commit 4664fd1

Browse files
committed
refactor(pagi): cleanup & naming adjust
1 parent 825c9f3 commit 4664fd1

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

lib/groupher_server/accounts/delegates/collect_folder.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ defmodule GroupherServer.Accounts.Delegate.CollectFolder do
8282
end)
8383

8484
Repo.preload(folder.collects, article_preload)
85-
|> ORM.embeds_paginater(filter)
85+
|> ORM.embeds_paginator(filter)
8686
|> ORM.extract_articles()
8787
|> done()
8888
end

lib/helper/orm.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ defmodule Helper.ORM do
2929

3030
# NOTE: should have limit length for list, otherwise it will cause mem issues
3131
@doc "simu paginator in normal list, used for embeds_many etc"
32-
def embeds_paginater(list, %{page: page, size: size} = _filter) when is_list(list) do
32+
def embeds_paginator(list, %{page: page, size: size} = _filter) when is_list(list) do
3333
chunked_list = Enum.chunk_every(list, size)
3434

3535
entries = chunked_list |> Enum.at(page - 1)

test/helper/orm_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ defmodule GroupherServer.Test.Helper.ORM do
7575
end)
7676

7777
filter = %{page: 1, size: 30}
78-
result = ORM.embeds_paginater(list, filter)
78+
result = ORM.embeds_paginator(list, filter)
7979

8080
assert result |> is_valid_pagination?(:raw)
8181
assert result.total_count == length(list)
@@ -85,7 +85,7 @@ defmodule GroupherServer.Test.Helper.ORM do
8585
assert result.entries |> List.last() == "i-30"
8686

8787
filter = %{page: 4, size: 30}
88-
result = ORM.embeds_paginater(list, filter)
88+
result = ORM.embeds_paginator(list, filter)
8989

9090
assert result.page_number == 4
9191
assert result.entries |> List.first() == "i-91"

0 commit comments

Comments
 (0)