refactor(cms-macros): unused emotion config

Author: mydearxym

config/config.exs

@@ -61,7 +61,6 @@ config :groupher_server, :customization,
   sidebar_communities_index: %{}
 
 config :groupher_server, :article,
-  emotionable_threads: [:post, :job],
   # NOTE: if you want to add/remove emotion, just edit the list below
   # and migrate the field to table "articles_users_emotions"
   supported_emotions: [

lib/groupher_server/cms/article_comment.ex

@@ -78,7 +78,6 @@ defmodule GroupherServer.CMS.ArticleComment do
     has_many(:upvotes, {"articles_comments_upvotes", ArticleCommentUpvote})
 
     article_belongs_to()
-
     timestamps(type: :utc_datetime)
   end
 

lib/groupher_server/cms/article_user_emotion.ex

@@ -23,25 +23,25 @@ defmodule GroupherServer.CMS.ArticleUserEmotion do
   import Ecto.Changeset
   import GroupherServer.CMS.ArticleUserEmotion.Macros
   import Helper.Utils, only: [get_config: 2]
+  import GroupherServer.CMS.Helper.Macros
+  import GroupherServer.CMS.Helper.Utils, only: [articles_foreign_key_constraint: 1]
 
   alias GroupherServer.{Accounts, CMS}
-  alias CMS.{Post, Job}
 
   @supported_emotions get_config(:article, :supported_emotions)
-  @supported_threads get_config(:article, :emotionable_threads)
+  @article_threads CMS.Community.article_threads()
 
   @required_fields ~w(user_id recived_user_id)a
-  @optional_fields Enum.map(@supported_threads, &:"#{&1}_id") ++
+  @optional_fields Enum.map(@article_threads, &:"#{&1}_id") ++
                      Enum.map(@supported_emotions, &:"#{&1}")
 
   @type t :: %ArticleUserEmotion{}
   schema "articles_users_emotions" do
-    belongs_to(:post, Post, foreign_key: :post_id)
-    belongs_to(:job, Job, foreign_key: :job_id)
     belongs_to(:recived_user, Accounts.User, foreign_key: :recived_user_id)
     belongs_to(:user, Accounts.User, foreign_key: :user_id)
 
     emotion_fields()
+    article_belongs_to()
     timestamps(type: :utc_datetime)
   end
 
@@ -50,19 +50,17 @@ defmodule GroupherServer.CMS.ArticleUserEmotion do
     struct
     |> cast(attrs, @required_fields ++ @optional_fields)
     |> validate_required(@required_fields)
-    # |> foreign_key_constraint(:post_id)
-    # |> foreign_key_constraint(:job_id)
     |> foreign_key_constraint(:user_id)
     |> foreign_key_constraint(:recived_user_id)
+    |> articles_foreign_key_constraint
   end
 
   def update_changeset(%ArticleUserEmotion{} = struct, attrs) do
     struct
     |> cast(attrs, @required_fields ++ @optional_fields)
     |> validate_required(@required_fields)
-    # |> foreign_key_constraint(:post_id)
-    # |> foreign_key_constraint(:job_id)
     |> foreign_key_constraint(:user_id)
     |> foreign_key_constraint(:recived_user_id)
+    |> articles_foreign_key_constraint
   end
 end

priv/repo/migrations/20210516144011_add_repo_support_in_emotion.exs

@@ -0,0 +1,9 @@
+defmodule GroupherServer.Repo.Migrations.AddRepoSupportInEmotion do
+  use Ecto.Migration
+
+  def change do
+    alter table(:articles_users_emotions) do
+      add(:repo_id, references(:cms_repos, on_delete: :delete_all))
+    end
+  end
+end

test/groupher_server/cms/comments/post_comment_test.exs

@@ -350,6 +350,7 @@ defmodule GroupherServer.Test.CMS.Comments.PostComment do
       assert results.total_count == total_count + 1
     end
 
+    @tag :wip2
     test "paged article comments folded flag should be false", ~m(user post)a do
       total_count = 30
       page_number = 1