refactor(pin-article): basic workflow

Author: mydearxym

lib/groupher_server/cms/cms.ex

@@ -86,6 +86,7 @@ defmodule GroupherServer.CMS do
   # ArticleOperation
   # >> set flag on article, like: pin / unpin article
   defdelegate set_community_flags(community_info, queryable, attrs), to: ArticleOperation
+  defdelegate pin_article(thread, id, community_id), to: ArticleOperation
   defdelegate pin_content(queryable, community_id), to: ArticleOperation
   defdelegate undo_pin_content(queryable, community_id), to: ArticleOperation
 

lib/groupher_server/cms/delegates/article_operation.ex

@@ -6,7 +6,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
   import Ecto.Query, warn: false
   # import Helper.ErrorCode
   import ShortMaps
+  import GroupherServer.CMS.Utils.Matcher2
 
+  alias Helper.Types, as: T
   alias Helper.ORM
 
   alias GroupherServer.CMS.{
@@ -18,6 +20,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
     JobCommunityFlag,
     RepoCommunityFlag,
     Tag,
+    PinedArticle,
     PinedPost,
     PinedJob,
     PinedRepo
@@ -26,6 +29,15 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
   alias GroupherServer.CMS.Repo, as: CMSRepo
   alias GroupherServer.Repo
 
+  @spec pin_article(T.article_thread(), Integer.t(), Integer.t()) :: {:ok, PinedArticle.t()}
+  def pin_article(thread, article_id, community_id) do
+    with {:ok, info} <- match(thread),
+         {:ok, community} <- ORM.find(Community, community_id) do
+      args = Map.put(%{community_id: community.id}, info.foreign_key, article_id)
+      PinedArticle |> ORM.create(args)
+    end
+  end
+
   def pin_content(%Post{id: post_id}, %Community{id: community_id}) do
     with {:ok, pined} <-
            ORM.findby_or_insert(

lib/groupher_server/cms/pined_article.ex

@@ -0,0 +1,34 @@
+defmodule GroupherServer.CMS.PinedArticle do
+  @moduledoc false
+  alias __MODULE__
+
+  use Ecto.Schema
+  import Ecto.Changeset
+
+  alias GroupherServer.CMS
+  alias CMS.{Community, Post, Job}
+
+  @required_fields ~w(community_id)a
+  @optional_fields ~w(post_id job_id)a
+
+  @type t :: %PinedArticle{}
+  schema "pined_articles" do
+    belongs_to(:post, Post, foreign_key: :post_id)
+    belongs_to(:job, Job, foreign_key: :job_id)
+    belongs_to(:community, Community, foreign_key: :community_id)
+
+    timestamps(type: :utc_datetime)
+  end
+
+  @doc false
+  def changeset(%PinedArticle{} = pined_article, attrs) do
+    pined_article
+    |> cast(attrs, @optional_fields ++ @required_fields)
+    |> validate_required(@required_fields)
+    |> foreign_key_constraint(:post_id)
+    |> foreign_key_constraint(:job_id)
+    |> foreign_key_constraint(:community_id)
+
+    # |> unique_constraint(:pined_posts, name: :pined_posts_post_id_community_id_index)
+  end
+end

priv/repo/migrations/20210429014800_create_pined_article.exs

@@ -0,0 +1,18 @@
+defmodule GroupherServer.Repo.Migrations.CreatePinedArticle do
+  use Ecto.Migration
+
+  def change do
+    create table(:pined_articles) do
+      add(:post_id, references(:cms_posts, on_delete: :delete_all))
+      add(:job_id, references(:cms_jobs, on_delete: :delete_all))
+      add(:community_id, references(:communities, on_delete: :delete_all), null: false)
+
+      timestamps()
+    end
+
+    create(index(:pined_articles, [:post_id]))
+    create(index(:pined_articles, [:job_id]))
+    create(index(:pined_articles, [:community_id]))
+    create(unique_index(:pined_articles, [:post_id, :job_id, :community_id]))
+  end
+end

test/groupher_server/cms/article_pin_test.exs

@@ -0,0 +1,78 @@
+defmodule GroupherServer.Test.CMS.ArticlePin do
+  use GroupherServer.TestTools
+
+  alias Helper.ORM
+  alias GroupherServer.CMS
+
+  alias CMS.{
+    PinedArticle,
+    Post,
+    Job
+  }
+
+  setup do
+    {:ok, user} = db_insert(:user)
+    {:ok, community} = db_insert(:community)
+
+    {:ok, post} = CMS.create_content(community, :post, mock_attrs(:post), user)
+    {:ok, job} = CMS.create_content(community, :job, mock_attrs(:job), user)
+    {:ok, repo} = CMS.create_content(community, :repo, mock_attrs(:repo), user)
+
+    {:ok, ~m(user community post job repo)a}
+  end
+
+  describe "[cms post pin]" do
+    @tag :wip2
+    test "can pin a post", ~m(community post)a do
+      {:ok, _} = CMS.pin_article(:post, post.id, community.id)
+      {:ok, pind_article} = ORM.find_by(PinedArticle, %{post_id: post.id})
+
+      assert pind_article.post_id == post.id
+    end
+
+    @tag :wip2
+    test "can not pin a non-exsit post", ~m(community post)a do
+      assert {:error, _} = CMS.pin_article(:post, 8848, community.id)
+    end
+
+    # test "can undo pin to a post", ~m(community post)a do
+    #   {:ok, pined_post} = CMS.pin_content(post, community)
+    #   assert pined_post.id == post.id
+
+    #   assert {:ok, unpined} = CMS.undo_pin_content(post, community)
+    #   assert unpined.id == post.id
+    # end
+  end
+
+  # describe "[cms job pin]" do
+  #   test "can pin a job", ~m(community job)a do
+  #     {:ok, pined_job} = CMS.pin_content(job, community)
+
+  #     assert pined_job.id == job.id
+  #   end
+
+  #   test "can undo pin to a job", ~m(community job)a do
+  #     {:ok, pined_job} = CMS.pin_content(job, community)
+  #     assert pined_job.id == job.id
+
+  #     assert {:ok, unpined} = CMS.undo_pin_content(job, community)
+  #     assert unpined.id == job.id
+  #   end
+  # end
+
+  # describe "[cms repo pin]" do
+  #   test "can pin a repo", ~m(community repo)a do
+  #     {:ok, pined_repo} = CMS.pin_content(repo, community)
+
+  #     assert pined_repo.id == repo.id
+  #   end
+
+  #   test "can undo pin to a repo", ~m(community repo)a do
+  #     {:ok, pined_repo} = CMS.pin_content(repo, community)
+  #     assert pined_repo.id == repo.id
+
+  #     assert {:ok, unpined} = CMS.undo_pin_content(repo, community)
+  #     assert unpined.id == repo.id
+  #   end
+  # end
+end