Feature/messenger #31
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codersforcauses/website/qr8aa75pd |
| "node-sass": "^4.11.0", | ||
| "react": "^16.8.4", | ||
| "react-dom": "^16.8.4", |
There was a problem hiding this comment.
You manually altered package json instead of using renovate bot. This is going to cause merge conflicts. You can either accept it’s pr or not use it you can’t do both afaik
|
|
||
| export default class MyApp extends App { | ||
| static async getInitialProps (context: NextAppContext) { | ||
| const { Component, ctx } = context | ||
| static async getInitialProps ({ Component, ctx }: AppContext) { |
There was a problem hiding this comment.
If you want you can convert all class components now to functional ones now with hooks
There was a problem hiding this comment.
U can’t convert app and document to functional
| } from 'next/document' | ||
| import '../theme.scss' | ||
|
|
||
| export default class MyDocument extends Document { | ||
| static async getInitialProps (ctx: NextDocumentContext) { | ||
| static async getInitialProps (ctx: DocumentContext) { |
There was a problem hiding this comment.
You are adding changes for next as well in future I would suggest you split out the PRs. In this case you can make two PRs one for next and one for messanger that branches out from next branch
|
@JeremiahPinto merge this yourself if you don't want to use renovate bot cc @Drewbi so hes aware. |
No description provided.