Treat log files always as text when parsing with grep #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enforces grep to always treat log files as text, preventing it from ever outputing "Binary file /var/log/mysql/error.log matches" as an argument to `wsrep_start_position` (it may happen when that error.log file contains null pointers).
|
Thanks for the pull request! Unfortunately more files had to be fixed, so we had to do our own instead. Will be in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enforces grep to always treat log files as text, preventing it from ever outputting "Binary file /var/log/mysql/error.log matches" as an argument to
wsrep_start_position, which may happen when thaterror.logfile contains null pointers. More details in #410