-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FDA SPL Product to Substance (Active/Inactive/Moiety) #158
Conversation
@Bridg109 - NOTE: I was getting some errors from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR runs and returns data that looks like it should be useful to the researcher.
The one thing I would suggest it to change to TRUNCATE tables methods, instead of DROP TABLE. This will add benefit as we don't need to cascade which might cause issues on API and it also allows us to do append data as needed. See NADAC PR for an example
Should we consider adding in a API for 11 digit NDC for the active and inactive ingredient? Since we have the info seems like a quick thing to add the API |
we should also set a start date so this runs with out us triggering it. |
Could also consider merging the read sql functions into a for loop like done in NADAC. If we start trimming these then making a class and implementing will be easier...or maybe we just wait till we make the class |
Could consider merging the api keys calls into a single task with the download dataset. This would enforce atomiciticy on the dag...which is a BP |
Noting that most of these comments are about the RxNorm DAG as a whole, I would feel better about addressing these when we eventually do a class-based / TRUNCATE overhaul of our DAGs. I added it as a note to other tickets that relate to those topics so we don't forget. |
Resolves #79
Explanation
Added FDA SPL inactive ingredient, active ingredient, and active moiety staging tables/views.
Rationale
To support the Purdue research use case.
Tests
Ran DAG several times. Tested a query.