Airflow operator #215
Merged
Airflow operator #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrlegrand
approved these changes
Nov 4, 2023
lprzychodzien
force-pushed
the
airflow_operator
branch
from
0710b0e
to
36b51b5
Compare
jrlegrand
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
@lprzychodzien - why are these dag tasks here? Do we need to remove this file since you switched to the zip file vs API method?
There was a problem hiding this comment.
Or maybe just keep the load_json and load_df_to_pg tasks and get rid of the extract task?
| "fda_enforcement", | ||
| con=engine, | ||
| schema="datasource", | ||
| if_exists="append", |
There was a problem hiding this comment.
Now that we are kind of loading the full file every time, we probably want to change this to "replace" - "append" was used originally b/c we were loading week by week.
This was referenced Nov 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Made the following changes:
Did not change all DAGs, remaining DAGs that to be updated includes:
Tests
Tested each touched DAG with the following results: (:heavy_check_mark: means all tasks ran)